Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better support for solaire mode #23

Open
jumper047 opened this issue Jun 26, 2019 · 4 comments
Open

Better support for solaire mode #23

jumper047 opened this issue Jun 26, 2019 · 4 comments
Labels
defer deferred until some changes enhancement

Comments

@jumper047
Copy link
Contributor

It breaks solaire mode for this theme
ogdenwebb added a commit that referenced this issue Jun 26, 2019
@ogdenwebb
Change bg0 and pange face in valley-light. Adress #23.
d4f300e
@ogdenwebb ogdenwebb changed the title Missed bg0 color in valley light theme Better support for solaire mode Jun 26, 2019
@ogdenwebb
Copy link
Owner

Overall this package needs some tweaks in core to achieve better support for things like solaire-mode, though. I hope to have more free time to work with kaolin-themes this fall.

As a temporary workaround I've pushed a commit. Please test that and let me know if it's enough.

@jumper047
Copy link
Contributor Author

Hmm, bg0 solves this issue, but adding pane broke it again - text buffers becomes orange. I think it will be ok with "swap-bg" option in solaire mode, but this behavior is inconsistent with other kaolin themes

@ogdenwebb
Copy link
Owner

this behavior is inconsistent with other kaolin themes

The default behaviour of solaire-mode in kaolin-themes isn't polished yet. I tried to get solaire-mode work in my config, but alas it doesn't work seamlessly for me.

Meanwhile, I'm not sure how to achieve with solaire-mode what I want, but I provide this screenshot to give you an idea how it should look like.
valley-light

It means I wanna get ordinary text buffers and maybe the rest of buffers such as magit-status with default background color and keep minibuffer, sidebars, etc darker than main content.

@ogdenwebb ogdenwebb added enhancement defer deferred until some changes labels Jun 27, 2019
@jumper047
Copy link
Contributor Author

Sorry, there was something wrong with my config. My issue completely fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defer deferred until some changes enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jumper047 @ogdenwebb