Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installs the Incorrect Version of Deadly Boss Mods from wowinterface.com #370

Open
Ironlenny opened this issue Jun 29, 2022 · 6 comments
Open

Comments

@Ironlenny
Copy link

Ironlenny commented Jun 29, 2022

I'm running TBC classic which has a release version of "DBM-2.5.38-bcc", but strongbox keeps downloading the retail version. I've had to pin the addon so it won't try to download it, and keep it updated manually.

Addon link: https://www.wowinterface.com/downloads/info8814#info

@torkus
Copy link
Contributor

torkus commented Jun 29, 2022

hey @Ironlenny , thanks for opening a ticket.

Strongbox uses the wowinterface API for discovering an addon's latest releases. Unfortunately wowinterface.com is a bit ... weird. They didn't handle the transition to Classic/Classic-TBC very well and their addon web pages (like https://www.wowinterface.com/downloads/info8814#info) often have more releases on it than what is available via the API.

Their addon web pages often have lists of previous releases that are not available via the API, too.

There is also a discrepancy of about ~7k addons that are not available via the API that are on the website. It's not clear why.

I spent some time earlier this year tackling these and other problems and built https://github.com/ogri-la/strongbox-catalogue-builder. It's an effort to scrape every last bit of addon information from wowi's API and website that I can with plans to extend it to the github catalogue as well. I'm currently using it to build the wowinterface catalogue weekly but I need to publish the larger set of wowinterface data somehow and have Strongbox make use of it. I have nothing too important planned for next month's release, so I'll take it on then.

For now you're stuck doing what you're doing with manual updates, sorry.

@Ironlenny
Copy link
Author

That sucks. Thanks for the explanation. I don't envy you dealing with Wow interface's funky api.

@Ironlenny
Copy link
Author

I know this is error prone, but have you considered doing a simple sanity check on the file name? Mod authors typically append 'bcc' and 'classic' to non-retail versions.

@torkus
Copy link
Contributor

torkus commented Jul 5, 2022

I spent some time earlier this year tackling these and other problems and built https://github.com/ogri-la/strongbox-catalogue-builder.

Re-opening because I intend to address this problem this month.

I know this is error prone, but have you considered doing a simple sanity check on the file name? Mod authors typically append 'bcc' and 'classic' to non-retail versions.

The filenames from wowinterface are not checked for mentions of a game track, although there is plenty of that happening for Github addons, as that information is available in the API.

I've actually just checked the two different versions of the API they have (v3 and v4) and DBM is present in one but not the other. It's such a weird state of affairs and I just assumed the same set of addons would be present in one that were in the other but apparently not. It's not meant for the public so we're just left guessing. I'm grateful there is anything structured at all.

@torkus torkus reopened this Jul 5, 2022
@AcidWeb
Copy link

AcidWeb commented Jun 4, 2023

All issues are caused by the fact that the entire V3 API exist only for their abandoned client - Minion. V4 was created for a new major release of it that never came.

API never was updated to have feature parity with the site as Minion development was halted. A few categories (like addon compilations) of addons that are missing from API for the same reason - Minion was not equipped to handle them.

@ychromosome
Copy link

I am basically running into the same bug just with Classic SoD and Classic WotLK.

As you see here: https://www.wowinterface.com/downloads/info8814 There are two versions of Deadly Boss Mods, one for Classic SoD and one for the rest(?) which renders Strongbox not able to update to the correct version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants