Remove unecessary leak from Handler::default_options_with#653
Merged
kanarus merged 1 commit intoMar 26, 2026
Merged
Conversation
kanarus
added
T-handler
1Cln
pushed a commit
to 1Cln/ohkami
that referenced
this pull request
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This leak is actually not necessary because you do not need to move everything into future
Instead OPTIONS handler is refactored to compute response outside of future and only return dummy future with response
Another fix for #643
P.s. other leaks are all in request handlers too, and much harder to address, so I will need some time to consider them, hence from now one it will be one PR per leak 😅