Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Deprecate table #399

Open
mpourismaiel opened this issue Oct 7, 2018 · 4 comments · May be fixed by #565
Open

[Discussion] Deprecate table #399

mpourismaiel opened this issue Oct 7, 2018 · 4 comments · May be fixed by #565
Assignees
Labels
Milestone

Comments

@mpourismaiel
Copy link
Member

Table fragment and table support in item fragment can be removed in favor of markdown table. One thing that would be missed is hidden columns in smaller devices and another thing would be alignment. What do you think?

@stp-ip stp-ip added this to the v0.15.0 milestone Nov 19, 2018
@stp-ip
Copy link
Member

stp-ip commented Nov 19, 2018

I agree more and more. Our tables are not that readable. Markdown only ones are more limited, but styled nicely I think it's easier for the user.
Definitely needs more styling than comes by default.
For a functioning site something like this should be possible https://about.ejderrapgott.de/songs/.
So that would mean having the markdown as content in an item fragment. Styling should be similar I think.

@stp-ip stp-ip modified the milestones: v0.15.0, v0.16.0 Nov 25, 2018
@stp-ip
Copy link
Member

stp-ip commented Jan 3, 2019

I think this should be the first thing we tackle in v0.16.0.
This means with the v0.15.0 release, we should add a big note to demo code and the docs that the table fragment is deprecated and one should use markdown tables instead with new features for markdown tables coming in v0.16.0. What do you think?

Plain markdown support should be fine as a first step and then look into how a few "features" from the previous version could be done via configuration or inline snippets.

@stp-ip
Copy link
Member

stp-ip commented Jan 27, 2019

Currently markdown tables are not styled at all and just look like a huge blob of text. When moving to this, we should use our old design to support this. Just wanted to add this as context here.

@mpourismaiel mpourismaiel self-assigned this Apr 19, 2019
@mpourismaiel mpourismaiel linked a pull request May 10, 2019 that will close this issue
4 tasks
@stp-ip stp-ip modified the milestones: v0.16.0, v0.17.0 Dec 31, 2019
@stp-ip stp-ip modified the milestones: v0.17.0, v0.18.0 Apr 23, 2020
@stp-ip stp-ip modified the milestones: v0.17.1, v0.18.0 May 23, 2020
@stp-ip stp-ip modified the milestones: v0.17.3, v0.18.0 Jul 27, 2020
@stp-ip stp-ip modified the milestones: v0.17.4, v0.18.0 Oct 23, 2020
@orchid00
Copy link

how can I add style to markdown tables? @stp-ip I need badly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

3 participants