Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS not working past Hugo v76.5 #865

Open
spearw opened this issue Feb 10, 2022 · 15 comments
Open

JS not working past Hugo v76.5 #865

spearw opened this issue Feb 10, 2022 · 15 comments
Assignees
Labels
bug deps_hugo hugo dependency compatability issues

Comments

@spearw
Copy link
Contributor

spearw commented Feb 10, 2022

Is this a BUG REPORT or FEATURE REQUEST?:
bug

What happened:

Updating Hugo past v76.5 gives webpack_require error, and all the JS breaks. This looks like a known issue, so I won't go into it more.

What you expected to happen:

JS working

How to reproduce it (as minimally and precisely as possible):

Update Hugo past v76.5

Anything else we need to know?:

I want to update Hugo for some of their features to update my website. It seems like this is a longstanding issue with Syna, (I don't mind looking for a fix myself). Are there any leads that you have on fixing this issue so I don't have to start from ground 0? I will report back if I find a fix. Thanks!

Environment:

  • Syna Theme version:
  • Hugo version:
  • Others:
@stp-ip
Copy link
Member

stp-ip commented Feb 11, 2022

Known issue and PRs are welcome :)
For now using Hugo v76.5 is the solution, if asset compilation is necessary. Pages without asset compilation should work with later versions as well.

@stp-ip stp-ip added bug deps_hugo hugo dependency compatability issues labels Feb 11, 2022
@spearw
Copy link
Contributor Author

spearw commented Feb 16, 2022

Thanks for the response. This site I'm building is a side project for me, so the development is not progressing that quickly, but I was hoping you'd be able to point me in a direction for looking at updating Syna to be compatible with later versions with asset compilation. Thanks!

@stp-ip
Copy link
Member

stp-ip commented Feb 16, 2022

A bit more information here: #847
As far as I could track it down until I ran into not having enough time was it being related with the difference between webpack 4 and 5. But couldn't pin it down to a specific thing.

@stp-ip
Copy link
Member

stp-ip commented Feb 16, 2022

Looking into it and will update here how far I got.

@spearw
Copy link
Contributor Author

spearw commented Feb 16, 2022

Great. Thank you.

@stp-ip
Copy link
Member

stp-ip commented Feb 16, 2022

Should have a few more specifics tomorrow I reckon.

@stp-ip stp-ip self-assigned this Feb 16, 2022
@stp-ip
Copy link
Member

stp-ip commented Feb 19, 2022

Small update: Got it working with the latest Hugo version and think I know the culprit. Want to be sure on the whole issue before pushing it. Traveling next week, but afterwards should have a bit of time to finalize it.

@spearw
Copy link
Contributor Author

spearw commented Feb 22, 2022

That's excellent news!

@spearw
Copy link
Contributor Author

spearw commented Mar 3, 2022

Hey @stp-ip, any luck tracking down the culprit?

@stp-ip
Copy link
Member

stp-ip commented Mar 3, 2022

A few things came up 😅, but have it on my list for next week. 🤞

@spearw
Copy link
Contributor Author

spearw commented Mar 3, 2022

Super! I really appreciate this project and the work you're putting in.

@stp-ip
Copy link
Member

stp-ip commented Mar 16, 2022

Had quite a few urgent refugee projects take up our time. We or I will get back to this as soon as possible.

@spearw
Copy link
Contributor Author

spearw commented Mar 17, 2022

No worries. Thanks for letting me know.

@ilgun
Copy link

ilgun commented Mar 20, 2022

Subscribing to this one as well.

@Natureshadow
Copy link

I found out that disbaling JS minification works around the issue:

[minify]
disableJS = true

Thus, I think this issue came up with the bump of tdewolff/minify in Hugo 0.77.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug deps_hugo hugo dependency compatability issues
Development

No branches or pull requests

4 participants