Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: okta/okta-auth-js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: okta-auth-js-1.13.0
Choose a base ref
...
head repository: okta/okta-auth-js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Loading
Showing 1,316 changed files with 125,477 additions and 12,838 deletions.
136 changes: 136 additions & 0 deletions .bacon.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,136 @@
test_suites:
- name: publish
script_path: ../okta-auth-js/scripts
sort_order: '1'
timeout: '60'
script_name: publish
criteria: MERGE
queue_name: small
- name: lint
script_path: ../okta-auth-js/scripts
sort_order: '2'
timeout: '60'
script_name: lint
criteria: MERGE
queue_name: small
log_files:
- build2/reports/lint/eslint-checkstyle-result.xml

- name: unit
script_path: ../okta-auth-js/scripts
sort_order: '2'
timeout: '20'
script_name: unit
criteria: MERGE
queue_name: small
- name: integration
script_path: ../okta-auth-js/scripts
sort_order: '3'
timeout: '10'
script_name: integration
criteria: MERGE
queue_name: small

- name: e2e
script_path: ../okta-auth-js/scripts/e2e
sort_order: '4'
timeout: '20'
script_name: e2e
criteria: MERGE
queue_name: small
- name: e2e-cucumber
script_path: ../okta-auth-js/scripts/e2e
sort_order: '4'
timeout: '20'
script_name: e2e-cucumber
criteria: MERGE
queue_name: small
- name: e2e-mfa
script_path: ../okta-auth-js/scripts/e2e
sort_order: '5'
timeout: '10'
script_name: e2e-mfa
criteria: MERGE
queue_name: small
- name: e2e-dpop
script_path: ../okta-auth-js/scripts/e2e
sort_order: '5'
timeout: '10'
script_name: e2e-dpop
criteria: MERGE
queue_name: small
- name: sample-express-embedded-auth-with-sdk
script_path: ../okta-auth-js/scripts/samples
sort_order: '6'
timeout: '30'
script_name: e2e-express-embedded-auth-with-sdk
criteria: MERGE
queue_name: small
- name: sample-express-web-no-oidc
script_path: ../okta-auth-js/scripts/samples
sort_order: '7'
timeout: '15'
script_name: e2e-express-web-no-oidc
criteria: MERGE
queue_name: small
- name: sample-express-web-with-oidc
script_path: ../okta-auth-js/scripts/samples
sort_order: '8'
timeout: '15'
script_name: e2e-express-web-with-oidc
criteria: MERGE
queue_name: small
- name: sample-static-spa
script_path: ../okta-auth-js/scripts/samples
sort_order: '9'
timeout: '15'
script_name: e2e-static-spa
criteria: MERGE
queue_name: small
- name: sample-webpack-spa
script_path: ../okta-auth-js/scripts/samples
sort_order: '10'
timeout: '15'
script_name: e2e-webpack-spa
criteria: MERGE
queue_name: small
- name: sample-express-embedded-sign-in-widget
script_path: ../okta-auth-js/scripts/samples
sort_order: '11'
timeout: '15'
script_name: e2e-express-embedded-sign-in-widget
criteria: MERGE
queue_name: small
- name: sample-react-embedded-auth-with-sdk
script_path: ../okta-auth-js/scripts/samples
sort_order: '12'
timeout: '20'
script_name: e2e-react-embedded-auth-with-sdk
criteria: MERGE
queue_name: small

- name: verify-registry-install
prereq_test_suite_name: publish
script_path: ../okta-auth-js/scripts
sort_order: '13'
timeout: '20'
script_name: verify-registry-install
criteria: MERGE
queue_name: small
# Sauce labs tests are flaky due to the free account we are currently using
# Re-enable this task on bacon once we have an paid account
# - name: e2e-saucelabs
# script_path: ../okta-auth-js/scripts
# sort_order: '8'
# timeout: '60'
# script_name: e2e-saucelabs
# criteria: MERGE
# queue_name: small

- name: semgrep
script_path: ../okta-auth-js/scripts
sort_order: '14'
timeout: '10'
script_name: semgrep
criteria: MERGE
queue_name: small
31 changes: 20 additions & 11 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,11 +1,20 @@
/lib/vendor
/test/vendor
/test/xhr
/.grunt
/buildtools
/dist
/target
/node_modules
Gruntfile.js
*.config.js
/lib/config.js
/test/support/xhr
/test/app/public
/test/apps/app/public
node_modules
/build/dist
/build/lib
/build/types
/build/cjs
/build/esm
/build/umd
/samples/templates
/samples/generated/webpack-spa/public/*-bundle.*
/samples/generated/express-direct-auth-dynamic
.eslintrc.js
dist
target
/test/apps/app/public/oidc-app.js
/test/apps/app/target
/test/apps/tree-shaking/target
/scripts/dockolith
212 changes: 212 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,212 @@
module.exports = {
extends: [
"eslint:recommended",
"plugin:@typescript-eslint/eslint-recommended",
"plugin:node/recommended-script",
"plugin:@typescript-eslint/recommended",
"plugin:jsdoc/recommended"
],
env: {
browser: false,
commonjs: true,
node: true
},
globals: {
Promise: true,
console: true,
setTimeout: true,
clearTimeout: true,
setInterval: true,
clearInterval: true
},
settings: {
jsdoc: {
mode: "typescript",
definedTags: [
"type"
]
}
},
overrides: [
{
files: ["*.ts"],
plugins: [
"@typescript-eslint"
],
parser: "@typescript-eslint/parser",
rules: {
// https://typescript-eslint.io/docs/linting/troubleshooting/#i-am-using-a-rule-from-eslint-core-and-it-doesnt-work-correctly-with-typescript-code
"no-undef": "off",
"no-unused-vars": "off",
"@typescript-eslint/no-unused-vars": "error",
}
},
{
files: ["samples/generated/**/*"],
rules: {
"@typescript-eslint/ban-ts-comment": "off"
}
},
{
files: ["polyfill/**/*", "build/polyfill/**/*"],
env: {
browser: true
},
rules: {
"node/no-unsupported-features/node-builtins": ["error", {
ignores: ["TextEncoder", "TextDecoder"]
}]
}
},
{
files: ["test/types/*.ts"],
env: {
browser: true,
node: true
},
rules: {
"node/no-unsupported-features/es-syntax": 0,
"node/no-extraneous-import": 0,
"no-unused-vars": 0,
"@typescript-eslint/no-unused-vars": 0,
"max-statements": 0
}
},
{
files: ["build/**/*.js"],
rules: {
"node/no-unpublished-require": 1,
"node/no-unpublished-import": 1
}
},
{
files: ["{lib,build/lib}/{browser/*,crypto,oidc/util/pkce}.{js,ts}"],
rules: {
"node/no-unsupported-features/node-builtins": ["error", {
ignores: ["TextEncoder"]
}]
}
},
{
files: [
"lib/**/*"
],
plugins: [
"@typescript-eslint",
"jsdoc",
// https://github.com/import-js/eslint-plugin-import#typescript
'import',
],
extends: [
'plugin:import/recommended',
'plugin:import/typescript'
],
parser: "@typescript-eslint/parser",
parserOptions: {
project: "./tsconfig.json",
tsconfigRootDir: "./"
},
rules: {
"node/no-missing-import": ["error", {
allowModules: [
"@okta/okta-auth-js"
],
tryExtensions: [".js", ".ts"]
}],
// https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-extraneous-dependencies.md
'import/no-extraneous-dependencies': ['error', {
'devDependencies': false
}],
'node/no-unsupported-features/es-builtins': ['error', {
// features that are not supported before v14 are transformed in babel.cjs.js for commonjs output
version: '>=14.0.0'
}],
'import/no-commonjs': 'error',
"jsdoc/check-tag-names": 0
},
settings: {
// https://github.com/import-js/eslint-plugin-import#typescript
'import/parsers': {
'@typescript-eslint/parser': ['.ts']
}
},
},
{
files: ["samples/generated/**/*.js"],
rules: {
'node/no-missing-import': ['error', {
allowModules: ['@okta/okta-auth-js']
}],
'node/no-missing-require': ['error', {
allowModules: ['@okta/okta-auth-js']
}]
}
},
{
files: [
"rollup.config.js",
"**/*.mjs"
],
rules: {
"node/no-unsupported-features/es-syntax": 0
}
}
],
rules: {
"no-var": 0,
"prefer-rest-params": 0,
"prefer-spread": 0,
"prefer-const": 0,
"node/no-unpublished-require": 0,
"node/no-unpublished-import": 0,
camelcase: 2,
complexity: [2, 7],
curly: 2,
"dot-notation": 0,
"guard-for-in": 2,
"new-cap": [2, { properties: false }],
"no-caller": 2,
"no-empty": 2,
"no-eval": 2,
"no-implied-eval": 2,
"no-multi-str": 0,
"no-new": 2,
"no-plusplus": 0,
"no-undef": 2,
"no-use-before-define": [2, "nofunc"],
"no-unused-expressions": [2, { allowShortCircuit: true, allowTernary: true }],
"no-unused-vars": 2,
"max-depth": [2, 3],
"max-len": [2, 120],
"max-params": [2, 5],
"max-statements": [2, 25],
quotes: [2, "single", { allowTemplateLiterals: true }],
semi: 2,
strict: 0,
"wrap-iife": [2, "any"],
"no-throw-literal": 2,
"@typescript-eslint/no-var-requires": 0,
"@typescript-eslint/explicit-function-return-type": 0,
"@typescript-eslint/camelcase": 0,
"@typescript-eslint/no-this-alias": 0,
"@typescript-eslint/no-empty-function": 0,
"@typescript-eslint/no-use-before-define": 0,
"@typescript-eslint/ban-ts-ignore": 0,
"@typescript-eslint/no-explicit-any": 0,
"@typescript-eslint/interface-name-prefix": 0,
"@typescript-eslint/triple-slash-reference": 0,
"jsdoc/require-jsdoc": 0,
"jsdoc/require-param": 0,
"jsdoc/require-returns-description": 0,
"jsdoc/require-param-description": 0,
"jsdoc/require-returns": 0,
"jsdoc/no-undefined-types": 0,
"node/no-extraneous-require": ["error", {
allowModules: [
"@okta/okta-auth-js",
"@okta/env"
]
}]
},
root: true
}
Loading