Merge pull request #393 from okta/rn_android-exception-stack-trace

Add stack trace to android exceptions

Author: rajdeepnanua-okta

CHANGELOG.md

@@ -1,3 +1,8 @@
+# 2.10.0
+
+### Other
+- [#393](https://github.com/okta/okta-react-native/pull/393) Log stack traces for android exceptions
+
 # 2.9.1
 
 ### Bug Fix

android/src/main/java/com/oktareactnative/OktaSdkBridgeModule.java

@@ -55,6 +55,9 @@
 import com.okta.oidc.storage.SharedPreferenceStorage;
 import com.okta.oidc.util.AuthorizationException;
 
+import java.io.PrintWriter;
+import java.io.StringWriter;
+
 public class OktaSdkBridgeModule extends ReactContextBaseJavaModule implements ActivityEventListener {
 
     private static final String SESSION_CLIENT_SHARED_PREFS = "OKTA_SDK_BRIDGE_MODULE_SESSION_CLIENT";
@@ -254,8 +257,9 @@ public void onSuccess(@NonNull Result result) {
                         WritableMap params = Arguments.createMap();
                         params.putString(OktaSdkConstant.ERROR_CODE_KEY, OktaSdkError.SIGN_IN_FAILED.getErrorCode());
                         params.putString(OktaSdkConstant.ERROR_MSG_KEY, OktaSdkError.SIGN_IN_FAILED.getErrorMessage());
+                        params.putString(OktaSdkConstant.ERROR_STACK_TRACE_KEY, getStackTraceString(e));
                         sendEvent(reactContext, OktaSdkConstant.ON_ERROR, params);
-                        promise.reject(OktaSdkError.SIGN_IN_FAILED.getErrorCode(), OktaSdkError.SIGN_IN_FAILED.getErrorMessage());
+                        promise.reject(OktaSdkError.SIGN_IN_FAILED.getErrorCode(), OktaSdkError.SIGN_IN_FAILED.getErrorMessage(), e);
                     }
                 } else {
                     sharedPreferencesEditor.clear().apply();
@@ -273,8 +277,9 @@ public void onError(String error, AuthorizationException exception) {
                 WritableMap params = Arguments.createMap();
                 params.putString(OktaSdkConstant.ERROR_CODE_KEY, OktaSdkError.OKTA_OIDC_ERROR.getErrorCode());
                 params.putString(OktaSdkConstant.ERROR_MSG_KEY, error);
+                params.putString(OktaSdkConstant.ERROR_STACK_TRACE_KEY, getStackTraceString(exception));
                 sendEvent(reactContext, OktaSdkConstant.ON_ERROR, params);
-                promise.reject(OktaSdkError.OKTA_OIDC_ERROR.getErrorCode(), OktaSdkError.OKTA_OIDC_ERROR.getErrorMessage());
+                promise.reject(OktaSdkError.OKTA_OIDC_ERROR.getErrorCode(), OktaSdkError.OKTA_OIDC_ERROR.getErrorMessage(), exception);
             }
         });
     }
@@ -539,6 +544,7 @@ public void onSuccess(@NonNull AuthorizationStatus status) {
                         WritableMap params = Arguments.createMap();
                         params.putString(OktaSdkConstant.ERROR_CODE_KEY, OktaSdkError.SIGN_IN_FAILED.getErrorCode());
                         params.putString(OktaSdkConstant.ERROR_MSG_KEY, OktaSdkError.SIGN_IN_FAILED.getErrorMessage());
+                        params.putString(OktaSdkConstant.ERROR_STACK_TRACE_KEY, getStackTraceString(e));
                         if (promise != null) {
                             promise.reject(e);
                         }
@@ -576,6 +582,7 @@ public void onError(@NonNull String msg, AuthorizationException error) {
                 WritableMap params = Arguments.createMap();
                 params.putString(OktaSdkConstant.ERROR_CODE_KEY, OktaSdkError.OKTA_OIDC_ERROR.getErrorCode());
                 params.putString(OktaSdkConstant.ERROR_MSG_KEY, msg);
+                params.putString(OktaSdkConstant.ERROR_STACK_TRACE_KEY, getStackTraceString(error));
                 final Promise promise = queuedPromise;
                 if (promise != null) {
                     promise.reject(OktaSdkError.SIGN_IN_FAILED.getErrorCode(), params.copy());
@@ -728,6 +735,14 @@ private int getRecalculatedRequestCodeForActivityResult(
         return initialRequestCode;
     }
 
+    private String getStackTraceString(Exception e) {
+        StringWriter sw = new StringWriter();
+        PrintWriter pw = new PrintWriter(sw);
+        e.printStackTrace(pw);
+        pw.flush();
+        return sw.toString();
+    }
+
     private enum LastRequestType {
         SIGN_IN,
         SIGN_OUT

android/src/main/java/com/oktareactnative/OktaSdkConstant.java

@@ -31,6 +31,8 @@ final class OktaSdkConstant {
 
     static final String ERROR_MSG_KEY = "error_message";
 
+    static final String ERROR_STACK_TRACE_KEY = "error_stack_trace";
+
     static final String ACTIVE_KEY = "active";
 
     static final String TOKEN_TYPE_KEY = "token_type";