Skip to content

Updating Readme and default config file to clarify what the Org URL i… #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updating Readme and default config file to clarify what the Org URL i… #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions custom-login/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,15 @@ npm install
Now you need to gather the following information from the Okta Developer Console:

- **Client Id** - The client ID of the SPA application that you created earlier. This can be found on the "General" tab of an application, or the list of applications. This identifies the application that tokens will be minted for.
- **Issuer** - This is the URL of the authorization server that will perform authentication. All Developer Accounts have a "default" authorization server. The issuer is a combination of your Org URL (found in the upper right of the console home page) and `/oauth2/default`. For example, `https://dev-1234.oktapreview.com/oauth2/default`.
- **Issuer** - This is the URL of the authorization server that will perform authentication, containing your custom your Okta OrgURL, which can be found in the upper right of your developer console home page. (This is not the same as the URL you access your dev console at.) Once you copy/paste, it should look like: `https://dev-1234.oktapreview.com/oauth2/default`.

Now place these values into the file `src/.samples.config.js` that was created for you in this project:

```javascript
export default {
oidc: {
clientId: '{clientId}',
issuer: 'https://{yourOktaDomain}.com/oauth2/default',
Copy link
Contributor

@mraible mraible Mar 16, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value you deleted is the standard syntax we use to specify this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any ideas to provide clarity for new devs on the difference between Okta Domain, dev console domain, and Org URL? I pasted my dev console domain and got a 404.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add a note like this:

TIP: The value of {yourOktaDomain} should be something like dev-123456.oktapreview. Make sure you don't include -admin in the value!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that (although it wouldn't have helped me since I didn't read the comments before filling in the values.) Would it also make sense to change the "Org URL" in the dashboard to "Your Okta Domain" for clarity?

issuer: '{yourOktaOrgURL}/oauth2/default',
redirectUri: 'http://localhost:8080/implicit/callback',
scope: 'openid profile email',
},
Expand Down
2 changes: 1 addition & 1 deletion custom-login/util/default-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
export default {
oidc: {
clientId: '{clientId}',
issuer: 'https://{yourOktaDomain}.com/oauth2/default',
issuer: '{yourOktaOrgURL}/oauth2/default',
redirectUri: 'http://localhost:8080/implicit/callback',
scope: 'openid profile email',
},
Expand Down