Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The createClassifier() Method Is Final #38

Closed
oliverspryn opened this issue Mar 28, 2024 · 0 comments · Fixed by #39
Closed

The createClassifier() Method Is Final #38

oliverspryn opened this issue Mar 28, 2024 · 0 comments · Fixed by #39
Labels
Bug A defect which was discovered during development, testing, or while in production.
Milestone
1.2.1

Comments

@oliverspryn
Copy link
Owner

The whole point of making the Classifier class open was to open up its method, createClassifier(), to for extending. Since this method is still technically final, these changes are not entirely useful. The method should also be declared open.
@oliverspryn oliverspryn added the Bug A defect which was discovered during development, testing, or while in production. label Mar 28, 2024
@oliverspryn oliverspryn added this to the 1.2.1 milestone Mar 28, 2024
@oliverspryn oliverspryn linked a pull request Mar 28, 2024 that will close this issue
Fixes #38 The createClassifier() Method Is Final #39
Merged
oliverspryn added a commit that referenced this issue Mar 28, 2024
@oliverspryn
Fixes #38 The createClassifier() Method Is Final
b62efe2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A defect which was discovered during development, testing, or while in production.
Projects
Multimodal Spanner
Status: Done
Milestone
1.2.1
Development

Successfully merging a pull request may close this issue.

Fixes #38 The createClassifier() Method Is Final oliverspryn/multimodal-spanner
1 participant
@oliverspryn