Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create way to mark/fix incorrect locations #4

Open
olivierbouwman opened this issue Jan 21, 2022 · 1 comment
Open

Create way to mark/fix incorrect locations #4

olivierbouwman opened this issue Jan 21, 2022 · 1 comment

Comments

@olivierbouwman
Copy link
Owner

olivierbouwman commented Jan 21, 2022

Think of a way where people can mark locations as incorrect and propose a new location.
Consider the following:

  • Currently there's no database or server aside from a json file and static files. I would prefer keeping things that way.
  • Perhaps people can click on the correct place on the map to move a misplaced location to. Ask people to only take post text into consideration as to not locate things the post author didn't want located.
  • Perhaps someone can propose a correction and at least 1 other person has to approve before it's permanent?
  • If needed consider using some third-party service to store proposed changes before they make it into the data file (Google Sheets/Forms?)
  • What kind of abuse can we expect and how shall we deal with it?
    • Perhaps have a setting that can show/hide user submitted corrections.
    • Have a way to undo correction from a certain date range (remove from Google Form responses, revert datafile on github)

Current plan

  • Use Google Forms API to take location change submissions (it's free and can handle 5 million records).
  • Use Github Actions to periodically (hourly?) pull form submissions.
  • Process those form submissions and either mark items as "no location" or with the new proposed location. We probably always want to keep the original location as well, at least for now. Commit updated json file.
  • Alterations show up for people.

UX

  • Add link to each pin that says “fix location”.
  • A message appears with instructions:

Locations have been determined automatically based on the post text and sometimes it's wrong. You correction will help make this map better for everyone, thank you. Any changes you make will appear for everyone in about an hour.
For Hidden Portland posts only: Please base the correct location on the post text only. The original author might have desired a level of privacy and we need to respect that. Thank you.

  • Button: No location can be determined from the post text and this items should be removed from the map.
  • Button: Pick a new location
    • Adds a draggable pin. When you click on the pin, it shows “are you sure this is the correct new location?” Yes sends in location to Forms API, thanks for submission. No says "please move the pin to the correct location".
@olivierbouwman
Copy link
Owner Author

  • Allow removal of marker from map (if there's no location in the post text)

@olivierbouwman olivierbouwman reopened this Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant