Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Option to stop "Play background music" #298

Open
1 task done
gsxgmpkt9020 opened this issue Nov 29, 2024 · 3 comments
Open
1 task done

[Feature Request]: Option to stop "Play background music" #298

gsxgmpkt9020 opened this issue Nov 29, 2024 · 3 comments

Comments

@gsxgmpkt9020
Copy link

Preflight Checklist

  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe your suggested feature

It is quite annoying that "Play background music" is a default action. Users should have right to know that opencomic has this feature opened. Most people don't know this and will think this is a bug.

I usually need to open a cbz file in a folder which has all kinds of files including audio media.

Please give us a option to turn this off.

I found this function in #261.

I think "Play music in background in the folder" should not be turned on when most people don't know.

Additional Information

No response

Sample file

No response

@gsxgmpkt9020 gsxgmpkt9020 changed the title [Feature Request]: Option to "stop Play background music" [Feature Request]: Option to stop "Play background music" Nov 29, 2024
@ollm ollm self-assigned this Nov 29, 2024
@ollm ollm added this to the v1.3.2 milestone Nov 29, 2024
@ollm ollm added the question label Nov 29, 2024
@ollm
Copy link
Owner

ollm commented Nov 29, 2024

The option can be disabled with the icon that appears when music is present, it is a global option (like the magnifying glass) so it will apply to all folders.

Captura desde 2024-11-29 17-55-00

If you think that's better, I can change the default option for new installations to false.

readingMusic: {
play: true,
volume: 1.0,
},

@gsxgmpkt9020
Copy link
Author

change the default option for new installations to false

I think "change the default option for new installations to false" is better. Most people don't know this hidden function, and I find this owing to it played scary audio when I didn't want to

@ollm
Copy link
Owner

ollm commented Dec 1, 2024

You are right, it is better to activate it expressly if you want to use it (Mainly for Webtoons #149), I have changed it to false and the change will be in the next version b6346a7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants