Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Make the Ignore single folders option work for images too #299

Open
1 task done
ollm opened this issue Dec 4, 2024 · 3 comments
Open
1 task done
Assignees
Milestone

Comments

@ollm
Copy link
Owner

ollm commented Dec 4, 2024

Preflight Checklist

  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe your suggested feature

If the option Ignore single folders (Open automatically) is activated ignore single folders also in images.

For example, in the following case:

Folder name 01
└── Folder name 01
    └── File name 01.cbz
Folder name 02
└── Folder name 02
    ├── image 01.jpg
    └── image 02.jpg

It should be processed as if it were like this:

File name 01.cbz
Folder name 02
├── image 01.jpg
└── image 02.jpg

But not in the following cases:

Folder name
└── Folder name
    ├── File name 01.cbz
    ├── File name 02.cbz
    └── ...
Folder name
├── Folder name 01
│   ├── image 01.jpg
│   └── image 02.jpg
├── Folder name 02
│   ├── image 01.jpg
│   └── image 02.jpg
└── ...

Additional Information

Any chance this could be made to work such that if there is only one image displayed in the poster, it would always cover the whole poster instead of only one quarter?
For example, currently if a folder or archive contains only one subfolder, the poster shows the first image in the top-left corner and leaves the rest blank.

Originally posted by @ChameleonScales in #168 (comment)

Sample file

No response

@ollm ollm self-assigned this Dec 4, 2024
@ollm ollm added this to the v1.3.2 milestone Dec 4, 2024
@ChameleonScales
Copy link

ChameleonScales commented Dec 4, 2024

Thanks for your super-fast reactivity!
Your description corresponds to what I imagined.

Following your response on #168 :

It might work when the Ignore single folders (Open automatically) option is enabled, as it does something similar.

I tested that with OpenComic v1.3.1 and it doesn't seem to affect the poster.

Note: in my case I also have zip files, each containing a single folder. They go like this:

book.zip
└── single folder
    ├── page-1.jpg
    ├── page-2.jpg
    └── page-3.jpg

If they could also have the first image fill the poster that would be great.

In case you wonder why I would want to keep such a structure instead of moving the image files out of their parent folder, the main reason I remember is to prevent a potential mess when unzipping several zip files at once (some file browsers or scripts don't auto-generate a containing folder when unzipping, so without a parent folder in each archive, all the files of all the archives would be dumped in the current directory).

@ollm
Copy link
Owner Author

ollm commented Dec 4, 2024

I tested that with OpenComic v1.3.1 and it doesn't seem to affect the poster.

I think I explained it wrong, this option currently does nothing with posters/images, it only applies when opening folders, in this cases if you open a folder and there is only a sinle folder inside it, it will open automatically until there is more than one folder or there are no more folders to open.

So what I wanted to say is that the same could be done with posters/images when this option is active, which is not currently done.

@ChameleonScales
Copy link

ChameleonScales commented Dec 4, 2024

Thanks, I understand now and that would work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants