[Bug]: Tabs issue

[TristisOris]

Preflight Checklist

• I have searched the issue tracker for a bug report that matches the one I want to file, without success.

OpenComic Version

1.6.6 1a2d09a

Operating System

win11

Installed via

.exe

Steps to reproduce

• i opened some .cbz directly, then got an error.
• multiple open same .cbz creating a new tab.
• now need to close many tabs with mouse button click - need a close all option.

Expected Behavior

Actual Behavior

Error message

[Window Title]
Linenumber 86:21

[Main Instruction]
Error: Uncaught RangeError: Maximum call stack size exceeded at linenumber 86:21 of file file:///C:/Users/faust/AppData/Local/Programs/opencomic/resources/app.asar/.dist/tabs.mjs

[Content]
RangeError: Maximum call stack size exceeded
at getTabParentsIds (file:///C:/Users/faust/AppData/Local/Programs/opencomic/resources/app.asar/.dist/tabs.mjs:86:21)
at add (file:///C:/Users/faust/AppData/Local/Programs/opencomic/resources/app.asar/.dist/tabs.mjs:15:21)
at Object.openPath (file:///C:/Users/faust/AppData/Local/Programs/opencomic/resources/app.asar/.dist/tabs.mjs:121:12)
at openPathInNewTab (file:///C:/Users/faust/AppData/Local/Programs/opencomic/resources/app.asar/.dist/opencomic.js:399:24)
at file:///C:/Users/faust/AppData/Local/Programs/opencomic/resources/app.asar/.dist/opencomic.js:120:17
at CallbacksRegistry.apply (C:\Users\faust\AppData\Local\Programs\opencomic\resources\app.asar\node_modules@electron\remote\dist\src\renderer\callbacks-registry.js:54:29)
at C:\Users\faust\AppData\Local\Programs\opencomic\resources\app.asar\node_modules@electron\remote\dist\src\renderer\remote.js:353:23
at IpcRenderer. (C:\Users\faust\AppData\Local\Programs\opencomic\resources\app.asar\node_modules@electron\remote\dist\src\renderer\remote.js:335:13)
at IpcRenderer.emit (node:events:509:28)
at Object.onMessage (node:electron/js2c/renderer_init:2:13581)

[ОК]

Additional Information

No response

Sample file

No response

[ollm]

Thanks for reporting!

I still haven't been able to reproduce the issue of the infinite opening of the same file. However, this should fix the error message 07cdf95.

If you have any more information on how to reproduce the problem, I would appreciate it (For example, if it happened when opening multiple files quickly, etc.).

Nightly builds: ollm/OpenComic-Nightly

[TristisOris]

dunno. i just open the file.

[ollm]

I've made another change to prevent opening a file in a new tab if the file is already open 59aa933

Also, if you don't want files to open in new tabs, you can disable it in the settings under Navigation > Open files in a new tab.

Nightly builds: ollm/OpenComic-Nightly

[TristisOris]

Looks fixed now.

[Hadilan18]

In the latest update, I see that middle-click or right-click still opens the same book in a new tab. But regarding the auto tab switching behavior when opening the same book, I understand that some users might dislike duplicate tabs. However, forcing the app to switch tabs automatically is not a good idea. Firefox and Chrome open the same link in a new tab by default for a very good reason.

The Problem

If the app automatically switches tabs, it ruins a very common use case: cross-checking plot details.

Imagine a user reading a massive volume in fullscreen who wants to open the same book to double-check an earlier chapter without losing their current page. If the app forces tab switching, the user must open a New Window instead. This requires too many steps:

• Right-click ➔ Open in new window ➔ Press F11 to fullscreen ➔ Press Alt + Tab to change windows ➔ Press Alt + F4 to close.

This is too complicated and slow.

With duplicate tabs, the workflow is much easier:

• Middle-click to open duplicate tab ➔ Click between 2 tabs to check the plot (or use Ctrl + Tab / Ctrl + [1-9] once implemented) ➔ Click X to close.

This is faster, can be done with only one hand, and uses much less CPU/RAM than opening a new window (great for low-end computers).

The Suggestion

To satisfy both groups of users—those who open dozens of tabs, forget what is open, and get lost in crowded tab bars, and those who intentionally open dupes for cross-checking—I suggest keeping the duplicate tab, but making it easy to see. There are 2 ways:

1. Changing background or border color: When a user opens Tab B (which shares the exact same filepath as Tab A), the app scans the tab IDs/paths and applies a distinct border or background color to both tabs. This instantly signals that a duplicate exists somewhere on the tab bar. Once they close the duplicate tab, the color goes back to normal.
2. Auto Tab Grouping (similar to Chrome): Group duplicate tabs together with a small color block on the left. This solves the issue where a user has 20+ tabs open and the original tab is buried at the very beginning of the bar, making it hard to locate and rearrange manually.

Since Auto Tab Grouping is harder to code, simply changing the tab's border or background color is the most effective solution that works for the best of both worlds.

[TristisOris]

Just make this logic optional.

Browsers open multiple tabs only because they don't care about checking anything.

[ollm]

The change in 59aa933 only affects files opened from outside OpenComic (For example, from the file explorer). It is still possible to open multiple tabs for the same file when doing so from within the app itself.

[Hadilan18]

I understand. It is good to know that opening multiple tabs from within the app is still possible.

However, my suggestion about changing the tab color is purely for the UI. It does not matter where the file is opened from (inside or outside the app).

This is very important for users who prefer browsing books via File Explorer instead of the app's library, or users who unknowingly download duplicate volumes into different folders. They still need to open duplicate tabs to cross-check story details.

Once there are two tabs with the exact same book open, changing their color lets the user instantly see the duplicate. They can then easily rearrange them side-by-side to check the plot, or close them if they don't want duplicates.

To make this system highly accurate and consistent, the app can quickly check if a newly opened book matches any active tabs using these 3 fast steps:

1. Check File Path: If the paths are identical, trigger the color change. If not, go to step 2.
2. Check File Size: If the file sizes match exactly, go to step 3. If not, keep the normal color.
3. Check File Hash (First 1MB): Scan the hash ID of just the first 1MB of the file (takes only milliseconds). If the hashes match, trigger the color change. If not, keep the normal color.

This ensures the UI stays consistent even if the same book is opened from two different folders.