Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full coverage for tests from JSON-RPC specification #6

Open
6 tasks
omarjatoi opened this issue Aug 21, 2024 · 0 comments
Open
6 tasks

Full coverage for tests from JSON-RPC specification #6

omarjatoi opened this issue Aug 21, 2024 · 0 comments
Labels
enhancement New feature or request tests Improvements, fixes, or additions to the test suite.

Comments

@omarjatoi
Copy link
Owner

I added a first pass at the test suite, but some of the tests currently do not pass. There are also some tests missing:

The following tests are disabled because they are broken. They need to be fixed (likely in the client code to add some validations around parsing etc.) https://github.com/omarjatoi/json-rpc/blob/a14cc782d382e8dd0daf57356dfd3e3bba164095/test/json_rpc_test.erl#L69-L73

  • test_invalid_json
  • test_invalid_request_object
  • test_batch_invalid_json
  • test_empty_array
  • test_invalid_batch

The following tests are defined in the JSON-RPC 2.0 specification but not currently implemented:

  • rpc call with named parameters
@omarjatoi omarjatoi added enhancement New feature or request tests Improvements, fixes, or additions to the test suite. labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request tests Improvements, fixes, or additions to the test suite.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@omarjatoi