Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use react-create-class since React.createClass is deprecated #883

Closed

Conversation

wilkerlucio
Copy link
Contributor

@wilkerlucio wilkerlucio commented Jul 19, 2017

Closes #881

@dehli
Copy link

dehli commented Aug 3, 2017

I did some investigating last night about this (thanks for the tips @wilkerlucio!) and I've started to come up with an alternative solution here. The advantage would be that we wouldn't have to pull in create-react-class. Note my fork doesn't address line 903 in core.cljs. I need to spend some more time going through the code base to figure that out.

However, as I was reading through the code I realized that defui is just a React.Component class so maybe we could use that here instead (with some refactoring)?

@swannodette
Copy link
Member

Hrm shouldn't this PR bump the other React deps?

@wilkerlucio
Copy link
Contributor Author

wilkerlucio commented Aug 10, 2017

@swannodette React 16 is still in beta, you want that to be upgraded? I just used the createClass from 16 because that was the latest (and I don't think that matters much for this plugin). If you want I can upgrade React to beta, or downgrade the create-react-class to 15.5.3-0, what you think?

@anmonteiro anmonteiro mentioned this pull request Sep 29, 2017
@anmonteiro
Copy link
Contributor

Superseded by #892

@anmonteiro
Copy link
Contributor

Closing

@anmonteiro anmonteiro closed this Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants