WIP mod support #1313
WIP mod support #1313
Conversation
| @@ -0,0 +1,24 @@ | |||
| #ifndef MODMANAGER_H | |||
| #define MODMANAGER_H | |||
There was a problem hiding this comment.
modmanager seems unnecessarily long. Maybe just prefix with "mods_" ?
| #include "resources/af_move.h" | ||
| #include "resources/animation.h" | ||
| #include "resources/bk_info.h" | ||
| #include "utils/hashmap.h" |
There was a problem hiding this comment.
hashmap not used in header btw
Nopey
force-pushed
the
adt/mod-support
branch
from
38cfbe7 to
c95cddd
Compare
Vagabond
force-pushed
the
adt/mod-support
branch
from
49fe496 to
b401e12
Compare
| } | ||
| } | ||
| #ifdef OPUSFILE_FOUND | ||
| } else if(strcmp(".ogg", str_c(&ext)) == 0) { |
src/game/common_defines.c
Outdated
|
|
||
| for(int id = 0; id < num_hars; id++) { | ||
| if(strcasecmp(name, har_type_names[id]) == 0) { | ||
| if(omf_strncasecmp(name, har_type_names[id], strlen(har_type_names[id])) == 0) { |
There was a problem hiding this comment.
- if(strcasecmp(name, har_type_names[id]) == 0) {
+ if(omf_strncasecmp(name, har_type_names[id], strlen(har_type_names[id])) == 0) {these lines lines are not equivalent, as the latter is a "is har_type_names[id] a suffix of name?" test, wheres the former is an equality test.
Do not pass strlen into the length argument of strncasecmp, this is an anti-pattern.
Perhaps: omf_strncasecmp(name, har_type_names[id], SIZE_MAX), if you want to compare the whole strings? You could add this as a helper method, call it "omf_strcasecmp."
There was a problem hiding this comment.
correction: someone already added the omf_strcasecmp helper method, please use it.
openomf/src/utils/c_string_util.c
Line 55 in 5cf380f
Vagabond
force-pushed
the
adt/mod-support
branch
from
b50f862 to
7f414fd
Compare
Things to do:
Depends on #1312 to properly display high-res assets.