-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Blender Exporter Version to Generator String or Asset Extras #19
Comments
Feel like I have a pretty good idea of how to add this in. Just curious where it should go. Here is existing json from an exported glb. Where would we want to add the property?
Currently it exports for extensionsUsed as I've been reading up here: https://github.com/KhronosGroup/glTF-Blender-IO/tree/master/example-addons/example_gltf_extension And found in the example there was a version defined for an extension (unused in the final glb): https://github.com/KhronosGroup/glTF-Blender-IO/blob/master/example-addons/example_gltf_extension/__init__.py#L6 I assume Still digging but thought I'd seed the question on where version should be. I looked into adding it at the individual instance level but that didn't make sense. I think it should be somehow related to the Side question, Should extensionsUsed be |
Technically I believe the most recent consensus re: revisioning the spec itself was that this initial release represents conceptual 1.0, and any successor version would require its own standalone spec. Re: versioning the Blender OMI Add-On -- that still seems to be an open question. Personally I think appending |
Yeah, what @humbletim said. Either appending it to the generator property so that it shows up in other tools that already use it, or adding it to a new extras field. I'm not certain which is best yet though. |
Starting work here: humbletim/omi-blender-gltf#1 Currently that PR will allow us to create GLTF that look like this
|
Is this issue still relevant? The PR in the last comment has been merged. |
I'm going to add an |
We should put the version of the Blender Exporter in the exported glTF file so we can debug issues with the exporter.
The text was updated successfully, but these errors were encountered: