Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module doesn't work with Terraform 1.3.0 #11

Open
mbenson opened this issue Sep 27, 2022 · 1 comment
Open

Module doesn't work with Terraform 1.3.0 #11

mbenson opened this issue Sep 27, 2022 · 1 comment

Comments

@mbenson
Copy link

mbenson commented Sep 27, 2022

Describe the bug
Modules using optional object attributes via the experiments attribute of the terraform block are no longer valid with this latest release of the tool.

To Reproduce
Steps to reproduce the behavior:

https://github.com/mbenson/terraform-aws-eks-blueprints/tree/tf-130 is a branch containing my cut of updates to make the EKS blueprints project 1.3.0-compatible. Using e.g. examples/complete-kubernetes-addons you will find that terraform init returns a number of Error: Experiment has concluded messages, the first such pertaining to terraform/modules/eks_blueprints_kubernetes_addons.ondat/locals.tf.

Expected behavior
I would expect terraform init to succeed, at least, for our purposes here, with regard to this module.

Desktop (please complete the following information):

  • OS: MacOS
  • N/A
  • Version: EKS blueprints kubernetes-addons module points to v0.1.1 of ondat/ondat-addon/eksblueprints. Terraform version is, again, 1.3.0 .
@mbenson
Copy link
Author

mbenson commented Sep 27, 2022

I was in the process of submitting a PR for this issue, but there is a chicken-and-egg situation here that I think bears further discussion:

The changes required for this module are minimal and are represented at https://github.com/mbenson/terraform-eksblueprints-ondat-addon/tree/tf-130 . However, this module depends on https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/modules/kubernetes-addons/helm-addon which is also subject to the TF 1.3.0 incompatibility (aws-ia/terraform-aws-eks-blueprints#988). But because https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/modules/kubernetes-addons/ depends on this module neither entity can be fully fixed without the other. For my own testing I was able to confirm these changes worked by setting the module dependencies up with local filesystem source declarations, using my branch of the blueprints module at https://github.com/mbenson/terraform-aws-eks-blueprints/tree/tf-130 .

It may be possible to fix https://github.com/aws-ia/terraform-aws-eks-blueprints/tree/main/modules/kubernetes-addons/helm-addon first, then this one, then the remainder of https://github.com/aws-ia/terraform-aws-eks-blueprints/ (which as far as I can tell amounts to its modules/launch-templates but that's immaterial here). I am hoping the developers/community have some experience with coordinating changes between these modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant