Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: An electron build #98

Open
chmac opened this issue Sep 4, 2019 · 4 comments
Open

Feature: An electron build #98

chmac opened this issue Sep 4, 2019 · 4 comments
Assignees

Comments

@chmac
Copy link

chmac commented Sep 4, 2019

Firstly, this is an incredibly fantastic package. I've searched every so often for years for a web based mind mapping tool, that's open source, and this rocks. It totally lives up to the SLC motto. So huge thanks to the authors. 👍 👍 👍

Any interest in an electron build?

I'd love to have this running on my machine so it could auto save. I figure that's probably reasonably achievable with electron. I don't have much experience with electron, but I'm interested to experiment. Before going too far down this road, I wanted to check if you'd be interested in maintaining the electron build if I can get it to work? That might require a mac, as I think building for macOS is only possible on mac, not 100% sure though.

No worries if not. Maybe there's also other ways to package that don't require upkeep / maintenance. Or maybe an electron package could be auto updating, just wanted to solicit feedback from y'all before investigating too far...

@ondras
Copy link
Owner

ondras commented Sep 9, 2019

Hi @chmac,

an Electron-based build with local save/load sounds very nice! It should be doable right away; there is no reason to make this Mac-specific. It would work on every platform where Electron runs.

In my opinion, implementing this boils down to three distinct tasks:

  1. implementing the actual save/load operation using the existing MM.Backend API (using node's require("fs") to do the I/O stuff);

  2. creating an Electron app that loads the My Mind webpage;

  3. making the IO module (as per the first point) available in My Mind (only) when running inside Electron.

Ideally, the My Mind application shall be completely unaware that it runs under Electron; the only difference would be the availability of the "save to local filesystem" IO module.

I am, unfortunately, somewhat out of time these days. I will assign myself here, but please do not expect a swift resolution.

@ondras ondras self-assigned this Sep 9, 2019
@chmac
Copy link
Author

chmac commented Sep 9, 2019

@ondras Fully agree. I think the usual electron approach is to bundle the web part inside the app so it works offline. That would potentially mean to build a new electron version would require a Mac. But I fully agree, it makes sense to have a cross platform build. I'll also see if I can find time to invest in this. 👍

@DanielFrugoni
Copy link

Hope I can ask a question here about electron.

Have html like this:


(*NEVER GOES)

Now if I do:
this.router.navigate(['/init']); (it goes to)

@component({
selector: 'app-init',
templateUrl: './init.component.html',
styleUrls: ['./init.component.scss']
})
export class InitComponent implements OnInit {
constructor() { }
ngOnInit() { }
}

@NgModule({
declarations: [AppComponent,InitComponent]
....

Trying to work like Angular, what I doing wrong ?
Thx !

@ondras
Copy link
Owner

ondras commented Sep 16, 2019

Hope I can ask a question here about electron.

Sorry, this is not a general Electron support thread. Only discussions related to the current project (cyp) are allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants