Skip to content

Commit ba671f1

Browse files
committed
chore: fix modern clang errors.
Unused variable ext_written was reported by -Wunused-but-set-variable, so it's now guarded by the same preprocessor guards that protects its actual usage. Function without prototypes are note allowed in C23.
1 parent a7c39b1 commit ba671f1

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

e2fsck/extents.c

+8-1
Original file line numberDiff line numberDiff line change
@@ -201,9 +201,12 @@ static errcode_t rewrite_extent_replay(e2fsck_t ctx, struct extent_list *list,
201201
{
202202
errcode_t retval;
203203
ext2_extent_handle_t handle;
204-
unsigned int i, ext_written;
204+
unsigned int i;
205205
struct ext2fs_extent *ex, extent;
206206
blk64_t start_val, delta;
207+
#if defined(DEBUG) || defined(DEBUG_SUMMARY)
208+
unsigned int ext_written;
209+
#endif
207210

208211
/* Reset extent tree */
209212
inode->i_flags &= ~EXT4_EXTENTS_FL;
@@ -223,7 +226,9 @@ static errcode_t rewrite_extent_replay(e2fsck_t ctx, struct extent_list *list,
223226
if (retval)
224227
return retval;
225228

229+
#if defined(DEBUG) || defined(DEBUG_SUMMARY)
226230
ext_written = 0;
231+
#endif
227232

228233
start_val = ext2fs_get_stat_i_blocks(ctx->fs, EXT2_INODE(inode));
229234

@@ -263,7 +268,9 @@ static errcode_t rewrite_extent_replay(e2fsck_t ctx, struct extent_list *list,
263268
retval = ext2fs_extent_fix_parents(handle);
264269
if (retval)
265270
goto err;
271+
#if defined(DEBUG) || defined(DEBUG_SUMMARY)
266272
ext_written++;
273+
#endif
267274
}
268275

269276
delta = ext2fs_get_stat_i_blocks(ctx->fs, EXT2_INODE(inode)) -

lib/ss/test_ss.c

+1-3
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,7 @@ int main(int argc, char **argv)
136136
}
137137

138138

139-
void test_cmd (argc, argv)
140-
int argc;
141-
char **argv;
139+
void test_cmd (int argc, char** argv)
142140
{
143141
printf("Hello, world!\n");
144142
printf("Args: ");

0 commit comments

Comments
 (0)