Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onSuccess modifier not calling sometimes if used to with ImagePrefetcher at SwiftUI #2342

Open
TelOkan opened this issue Dec 25, 2024 · 3 comments

Comments

@TelOkan
Copy link

TelOkan commented Dec 25, 2024

Firstly thanks a lot for create like this library, it is amazing. 🎉

In my project i had to need use prefetch mechanism and noticed that if you are try to load same url at KFImage and ImagePrefetcher, some times onSuccess modifier not fire, And then KFImage not refresh itself.

Note: i fixed it in my project with didn't use the url at prefetch operation if the url used on KFImage. I wanted to inform you that there is such a bug.

In my project every time i can produce this case but in sample project rate is approximately ten to one.

Version: 7.11.0

Sample Project output.
https://github.com/user-attachments/assets/38da0395-5d57-4ac0-8236-a8be57faf747

@onevcat
Copy link
Owner

onevcat commented Jan 8, 2025

Thanks for sharing this... Let me check..

@onevcat
Copy link
Owner

onevcat commented Jan 12, 2025

I attempted to replicate the sample scene but was unable to reproduce the issue, even after more than 50 attempts.

Could you try testing this with the latest version of Kingfisher (8.1.3)? These latest v8 versions should include some fixes for thread-related issues and handler improvements. Maybe it helps.

@TelOkan
Copy link
Author

TelOkan commented Jan 13, 2025

Okey i will try with latest version. Thanks for feedback.

@TelOkan TelOkan closed this as completed Jan 14, 2025
@TelOkan TelOkan reopened this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants