Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SlabIterator should include nested storage ID (non-inlining feature branch) #397

Closed
fxamacker opened this issue Apr 26, 2024 · 1 comment
Closed

SlabIterator should include nested storage ID (non-inlining feature branch) #397

fxamacker opened this issue Apr 26, 2024 · 1 comment
Assignees
@fxamacker
Labels
bug Something isn't working

Comments

@fxamacker
Copy link
Member

This issue does not affect atree inlining feature branch.

Currently, SlabIterator doesn't traverse deep enough to handle nested storage ID inside another storable such as Cadence SomeValue.

SlabIterator is used by storage health check, which is used for tests and for new migration features like filtering out old unreferenced slabs, etc.
@fxamacker fxamacker added the bug Something isn't working label Apr 26, 2024
@fxamacker fxamacker self-assigned this Apr 26, 2024
@fxamacker fxamacker mentioned this issue Apr 26, 2024
Merged
6 tasks
@fxamacker
Copy link
Member Author

Closed by #398

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fxamacker fxamacker

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fxamacker