Add reasoning for skipping the comparison

Author: SupunS

interpreter/builtinfunctions_test.go

@@ -1153,6 +1153,8 @@ func TestInterpretNativeFunctionWithMultipleTypeParameters(t *testing.T) {
 	baseActivation := activations.NewActivation(nil, interpreter.BaseActivation)
 	interpreter.Declare(baseActivation, valueDeclaration)
 
+	// The native function is only for the VM when `compile` flag is on.
+	// Running the interpreter with that is not possible.
 	inter, err := parseCheckAndPrepareWithOptionsWithoutStorageComparison(t,
 		`
 		fun test() {

interpreter/member_test.go

@@ -44,6 +44,9 @@ func TestInterpretMemberAccessType(t *testing.T) {
 
 				t.Parallel()
 
+				// The passed in argument is created with VM.
+				// Therefore, the updates are only visible to VM.
+				// So comparing the storage is not possible.
 				inter := parseCheckAndPrepareWithoutStorageComparison(t, `
                     struct S {
                         var foo: Int
@@ -208,6 +211,9 @@ func TestInterpretMemberAccessType(t *testing.T) {
 
 				t.Parallel()
 
+				// The passed in argument is created with VM.
+				// Therefore, the updates are only visible to VM.
+				// So comparing the storage is not possible.
 				inter := parseCheckAndPrepareWithoutStorageComparison(t, `
                     struct interface SI {
                         var foo: Int
@@ -388,6 +394,9 @@ func TestInterpretMemberAccessType(t *testing.T) {
 
 				t.Parallel()
 
+				// The passed in argument is created with VM.
+				// Therefore, the updates are only visible to VM.
+				// So comparing the storage is not possible.
 				inter := parseCheckAndPrepareWithoutStorageComparison(t, `
                     struct S {
                         var foo: Int

interpreter/misc_test.go

@@ -4989,6 +4989,10 @@ func TestInterpretReferenceFailableDowncasting(t *testing.T) {
 		interpreter.Declare(baseActivation, valueDeclaration)
 
 		var err error
+
+		// This test manipulates the storage externally.
+		// But it only does that to the VM's storage.
+		// So comparing the storage is not possible.
 		inter, err = parseCheckAndPrepareWithOptionsWithoutStorageComparison(t,
 			`
 	              resource interface RI {}
@@ -12736,6 +12740,9 @@ func TestInterpretSomeValueChildContainerMutation(t *testing.T) {
 
 		newInter := func() Invokable {
 
+			// This test manipulates the storage externally.
+			// But it only does that to the VM's storage.
+			// So comparing the storage is not possible.
 			inter, err := parseCheckAndPrepareWithOptionsWithoutStorageComparison(t,
 				code,
 				ParseCheckAndInterpretOptions{
@@ -13450,6 +13457,8 @@ func TestInterpretVariableDeclarationSecondValueEvaluationOrder(t *testing.T) {
 		baseActivation := activations.NewActivation(nil, interpreter.BaseActivation)
 		interpreter.Declare(baseActivation, getKeyFunction)
 
+		// Uses a standard library with a closure.
+		// Using it in the interpreter make it count twice.
 		inter, err := parseCheckAndPrepareWithOptionsWithoutStorageComparison(
 			t,
 			fmt.Sprintf(`
@@ -13539,6 +13548,8 @@ func TestInterpretVariableDeclarationSecondValueEvaluationOrder(t *testing.T) {
 		interpreter.Declare(baseActivation, getKey1Function)
 		interpreter.Declare(baseActivation, getKey2Function)
 
+		// Uses a standard library with a closure.
+		// Using it in the interpreter make it count twice.
 		inter, err := parseCheckAndPrepareWithOptionsWithoutStorageComparison(
 			t,
 			`
@@ -13615,6 +13626,8 @@ func TestInterpretVariableDeclarationSecondValueEvaluationOrder(t *testing.T) {
 		baseActivation := activations.NewActivation(nil, interpreter.BaseActivation)
 		interpreter.Declare(baseActivation, getKeyFunction)
 
+		// Uses a standard library with a closure.
+		// Using it in the interpreter make it count twice.
 		inter, err := parseCheckAndPrepareWithOptionsWithoutStorageComparison(
 			t,
 			`
@@ -13703,6 +13716,8 @@ func TestInterpretVariableDeclarationSecondValueEvaluationOrder(t *testing.T) {
 		interpreter.Declare(baseActivation, getKey1Function)
 		interpreter.Declare(baseActivation, getKey2Function)
 
+		// Uses a standard library with a closure.
+		// Using it in the interpreter make it count twice.
 		inter, err := parseCheckAndPrepareWithOptionsWithoutStorageComparison(
 			t,
 			`
@@ -13781,6 +13796,8 @@ func TestInterpretVariableDeclarationSecondValueEvaluationOrder(t *testing.T) {
 		baseActivation := activations.NewActivation(nil, interpreter.BaseActivation)
 		interpreter.Declare(baseActivation, getKeyFunction)
 
+		// Uses a standard library with a closure.
+		// Using it in the interpreter make it count twice.
 		inter, err := parseCheckAndPrepareWithOptionsWithoutStorageComparison(
 			t,
 			`

interpreter/reference_test.go

@@ -910,6 +910,9 @@ func TestInterpretResourceReferenceInvalidationOnMove(t *testing.T) {
 
 		t.Parallel()
 
+		// The passed in argument is created with VM.
+		// Therefore, the value's slabs are only visible to VM's storage.
+		// So comparing the storage is not possible.
 		inter, err := parseCheckAndPrepareWithOptionsWithoutStorageComparison(t, `
             resource R {
                 access(all) var id: Int
@@ -2861,7 +2864,6 @@ func TestInterpretDereference(t *testing.T) {
 		})
 
 		t.Run("{Int: [String]}", func(t *testing.T) {
-			t.SkipNow()
 
 			inter := parseCheckAndPrepare(
 				t,