Change account linking pragma to run-time configuration of execution #2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 41f1c5b Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov Report
@@ Coverage Diff @@
## master #2380 +/- ##
=======================================
Coverage 78.50% 78.51%
=======================================
Files 316 316
Lines 68471 68492 +21
=======================================
+ Hits 53755 53774 +19
- Misses 12918 12920 +2
Partials 1798 1798
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dsainati1
approved these changes
Mar 13, 2023
6 tasks
SupunS
reviewed
Mar 13, 2023
…t pragma, add tests
SupunS
approved these changes
Mar 13, 2023
This was referenced Mar 13, 2023
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
Mar 14, 2023
4042: Update to Cadence v0.31.5-account-linking-improved-pragma r=turbolent a=turbolent See onflow/cadence#2380 Co-authored-by: Bastian Müller <[email protected]>
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
Mar 14, 2023
4042: Update to Cadence v0.31.5-account-linking-improved-pragma r=turbolent a=turbolent See onflow/cadence#2380 Co-authored-by: Bastian Müller <[email protected]>
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
Mar 14, 2023
4042: Update to Cadence v0.31.5-account-linking-improved-pragma r=turbolent a=turbolent See onflow/cadence#2380 Co-authored-by: Bastian Müller <[email protected]>
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
Mar 14, 2023
4042: Update to Cadence v0.31.5-account-linking-improved-pragma r=turbolent a=turbolent See onflow/cadence#2380 Co-authored-by: Bastian Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
#2353 introduced a pragma, which determines if the account linking function (
AuthAccount.linkAccount) is available.This is a static check: If the pragma is declared in the same program, the function is available, if the pragma is not declared, the function is not available.
This works well to allow wallets to detect transactions which attempt to use the account linking function, and potentially reject them. However, if the function is used in a contract, the current implementation requires the contract to declare the pragma, and a transaction which calls into the transaction does not need to declare the pragma. This prevents wallets from easily detecting a potential use of the account linking function.
Solution
Change the behaviour of the account linking pragma
#allowAccountLinkingfrom just a static check, to both a static check (as before, ensure the pragma is declared in the header of a program), and a dynamic check when the account linking function is called. The dynamic check requires that the pragma was declared.Changes
AuthAccount.linkAccountfunction, from being only defined when the pragma is defined in the same program, to being always available, independent of the pragmamasterbranchFiles changedin the Github PR explorer