Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Adhere to semantically versioned data structures #1881

Open
jribbink opened this issue May 17, 2024 · 0 comments
Open

[FEATURE] Adhere to semantically versioned data structures #1881

jribbink opened this issue May 17, 2024 · 0 comments
Assignees
Labels

Comments

@jribbink
Copy link
Contributor

Issue to be solved

Currently, FCL data models (e.g. services, responses, & other nested objects) are versioned (generally v1.0.0). However, the library does not perform and form of semantically versioned matching when "normalizing" these services.

The result is that FCL is unable to comprehend a version which, by the rules of semver, should be valid. (e.g. if FCL encounters a v1.1.0 authentication service, it cannot proceed, despite the fact that it should be compatible with all v1.x.x authentication services).

This is a part of a larger protocol issue related to versioning onflow/flips#238, however, it can likely be patched in FCL-JS independent from an FCL protocol bump. However, this wallets should not assume that FCL clients will honour semantic versioned data structures after the patch (as this assumption would break older FCL clients).

Suggest A Solution

No response

What are you currently working on that this is blocking?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

1 participant