Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] WalletConnect pairing cleanup #1948

Open
jribbink opened this issue Sep 9, 2024 · 0 comments
Open

[BUG] WalletConnect pairing cleanup #1948

jribbink opened this issue Sep 9, 2024 · 0 comments
Labels
Bug Something isn't working

Comments

@jribbink
Copy link
Contributor

jribbink commented Sep 9, 2024

Repeatedly connecting to an app can result in a large number of pairings being stored between the app and the wallet (if you repeatedly connect, you can look in the WalletConnect tab in Flow Wallet and see that there are a number of unused sessions).

This can be somewhat expensive in the WalletConnect protocol (theoretically, a very large number of pairings could put load on sign-client by opening a large number of subscriptions, so FCL should be able to either re-use or cleanup these pairings when duplicates are established).

Care must be taken to avoid destroying active pairings (i.e. be cognizant of any current/future use of concurrent sessions with the same wallet). This would suggest that the pairing re-use approach is probably more resilient than destroying existing pairings.

This was less of an issue in the previous iteration of FCL-WC's usage, as pairings were frequently re-used. However, in the new implementation with integrated QR codes, this problem is significantly amplified and should ideally be addressed before a production release (currently these changes are only in an alpha state).

@jribbink jribbink added Bug Something isn't working and removed Feature labels Sep 9, 2024
@jribbink jribbink changed the title [FEATURE] WalletConnect pairing cleanup [BUG] WalletConnect pairing cleanup Sep 9, 2024
@jribbink jribbink moved this to 🔖 Ready for Pickup in 🌊 Flow 4D Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: 🔖 Ready for Pickup
Development

No branches or pull requests

1 participant