You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One of the recent fixes published for FCL-WC changed deeplinking behaviour such that:
If authz WC/RPC request did not originate from a pre-authz service, it does not deeplink
If it did not originate from a pre-authz service, we still deeplink
This was a bit nuanced, but basically boiled down to:
We do not want to deep link for both pre-authz & authz requests
Ideally we would deeplink during authz since pre-authz is an auto-approval
However, suspended threads meant that pre-authz would hang unless app was in an active state
To avoid double linking we could just avoid deeplinking during authz since pre-authz already redirected the user to the dApp
The key oversight here was that not all pre-authz services returning an authz WC/RPC service will be WC/RPC services themselves.
This was highlighted in recent discussions with the Flow Wallet team, where they expressed their interest in migrating from WC/RPC pre-authz to an HTTP/POST pre-authz.
In this case, we would want to deeplink during authz, even though the request was initiated by a pre-authz service. This is because this pre-authz Service would be immediately responsive & the user would not already be in the wallet app prepared to approve their authz request. Critically, pre-authz service strategy matters here and we must act accordingly.
Suggest A Solution
Add an extra condition where we only disable authz deeplinking if the parent pre-authz was a WC/RPC service.
We should try to add this ASAP so that there is minimal impact to apps if the Flow Wallet team decides to migrate
What are you currently working on that this is blocking?
No response
The text was updated successfully, but these errors were encountered:
jribbink
changed the title
Restore FCL-WC deeplinking during authz request for certain situations
Restore FCL-WC deeplinking during authz request when initiated by non-WC/RPC pre-authz
Oct 30, 2024
Issue to be solved
One of the recent fixes published for FCL-WC changed deeplinking behaviour such that:
This was a bit nuanced, but basically boiled down to:
The key oversight here was that not all pre-authz services returning an authz WC/RPC service will be WC/RPC services themselves.
This was highlighted in recent discussions with the Flow Wallet team, where they expressed their interest in migrating from WC/RPC pre-authz to an HTTP/POST pre-authz.
In this case, we would want to deeplink during authz, even though the request was initiated by a pre-authz service. This is because this pre-authz Service would be immediately responsive & the user would not already be in the wallet app prepared to approve their authz request. Critically, pre-authz service strategy matters here and we must act accordingly.
Suggest A Solution
Add an extra condition where we only disable authz deeplinking if the parent pre-authz was a WC/RPC service.
We should try to add this ASAP so that there is minimal impact to apps if the Flow Wallet team decides to migrate
What are you currently working on that this is blocking?
No response
The text was updated successfully, but these errors were encountered: