Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore FCL-WC deeplinking during authz request when initiated by non-WC/RPC pre-authz #1998

Closed
Tracked by #1976
jribbink opened this issue Oct 29, 2024 · 0 comments · Fixed by #1999
Closed
Tracked by #1976
Assignees

Comments

@jribbink
Copy link
Contributor

jribbink commented Oct 29, 2024

Issue to be solved

One of the recent fixes published for FCL-WC changed deeplinking behaviour such that:

  • If authz WC/RPC request did not originate from a pre-authz service, it does not deeplink
  • If it did not originate from a pre-authz service, we still deeplink

This was a bit nuanced, but basically boiled down to:

  • We do not want to deep link for both pre-authz & authz requests
  • Ideally we would deeplink during authz since pre-authz is an auto-approval
  • However, suspended threads meant that pre-authz would hang unless app was in an active state
  • To avoid double linking we could just avoid deeplinking during authz since pre-authz already redirected the user to the dApp

The key oversight here was that not all pre-authz services returning an authz WC/RPC service will be WC/RPC services themselves.

This was highlighted in recent discussions with the Flow Wallet team, where they expressed their interest in migrating from WC/RPC pre-authz to an HTTP/POST pre-authz.

In this case, we would want to deeplink during authz, even though the request was initiated by a pre-authz service. This is because this pre-authz Service would be immediately responsive & the user would not already be in the wallet app prepared to approve their authz request. Critically, pre-authz service strategy matters here and we must act accordingly.

Suggest A Solution

Add an extra condition where we only disable authz deeplinking if the parent pre-authz was a WC/RPC service.

We should try to add this ASAP so that there is minimal impact to apps if the Flow Wallet team decides to migrate

What are you currently working on that this is blocking?

No response

@jribbink jribbink self-assigned this Oct 30, 2024
@jribbink jribbink moved this to 👀 In Review in 🌊 Flow 4D Oct 30, 2024
@jribbink jribbink changed the title Restore FCL-WC deeplinking during authz request for certain situations Restore FCL-WC deeplinking during authz request when initiated by non-WC/RPC pre-authz Oct 30, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in 🌊 Flow 4D Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant