Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to Local Storage #2002

Closed
Tracked by #1976
jribbink opened this issue Nov 13, 2024 · 0 comments · Fixed by #2001
Closed
Tracked by #1976

Default to Local Storage #2002

jribbink opened this issue Nov 13, 2024 · 0 comments · Fixed by #2001
Assignees

Comments

@jribbink
Copy link
Contributor

jribbink commented Nov 13, 2024

Currently FCL defaults to sessionStorage. We should change this default to localStorage as this has been a frequent complaint from users/developers. This was initially a security-conscious decision, but in practice it does not completely align with user/developer needs.

Reasons for switching:

  • Most major apps on flow use localStorage anyways
  • The security concerns re. persistent sessions were only really related to web wallets. These are largely being replaced by extension/mobile wallets
  • Web wallets can still define session expiry criteria themselves
  • Requiring constant re-authentication introduces lots of fricition in specific scenarios (e.g. Telegram apps, PWAs)
@jribbink jribbink changed the title Default to LocalStorage Default to Local Storage Nov 13, 2024
@github-project-automation github-project-automation bot moved this to ✅ Done in 🌊 Flow 4D Nov 13, 2024
@jribbink jribbink self-assigned this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant