Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript Fixes #1750

Merged
merged 16 commits into from
Aug 15, 2023
Merged

Typescript Fixes #1750

merged 16 commits into from
Aug 15, 2023

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Aug 10, 2023

What this PR does

  • Adds strict mode to default options. Can override on per package basis if necessary
  • Fixes eslint configuration & adds eslint to packages without it
  • Fixes tsconfig not being parsed properly (migration from @rollup/plugin-typescript to rollup-plugin-typescript2)
  • Fixes "types" key in package.json files (strict mode found these)
  • Removes type definitions from jsdoc and uses tsdoc + typescript types instead

Packages whose conversion this completes:
closes #1745. @onflow/rlp
closes #1744. @onflow/util-uid
closes #1743. @onflow/util-template
closes #1741. @onflow/util-logger
closes #1740. @onflow/util-invariant
closes #1739. @onflow/util-encode-key
closes #1738. @onflow/util-address

@jribbink jribbink changed the base branch from master to release-1.6 August 10, 2023 17:23
@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2023

🦋 Changeset detected

Latest commit: 90abe42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@onflow/fcl-bundle Minor
@onflow/util-encode-key Minor
@onflow/util-invariant Minor
@onflow/util-template Minor
@onflow/util-address Minor
@onflow/util-logger Minor
@onflow/util-uid Minor
@onflow/rlp Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jribbink jribbink changed the title [WIP] typescript fixes Typescript Fixes Aug 14, 2023
@jribbink jribbink marked this pull request as ready for review August 14, 2023 16:24
@jribbink jribbink requested a review from a team as a code owner August 14, 2023 16:24
Copy link
Contributor

@nialexsan nialexsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, great job!

@jribbink jribbink linked an issue Aug 15, 2023 that may be closed by this pull request
@jribbink jribbink merged commit 845ffa7 into release-1.6 Aug 15, 2023
1 check passed
@jribbink jribbink deleted the jribbink/ts-fixes branch August 15, 2023 21:49
nialexsan pushed a commit that referenced this pull request Nov 1, 2023
Implements typescript support for: @onflow/rlp, @onflow/util-uid, @onflow/util-template, @onflow/util-logger, @onflow/util-invariant, @onflow/util-encode-key, @onflow/util-address
nialexsan added a commit that referenced this pull request Nov 7, 2023
* Nialexsan/add types (#1710)

* switch to uuid from @onflow/utils-uid

* create tsconfigs

* typedefs in ts

* types for actor util

* types for address util

* Revert "switch to uuid from @onflow/utils-uid"

This reverts commit 2a15ef5.

* PKG -- [util-actor] converted to ts

* updated tsconfig

* fixed ts types generation

* Resolve circular dependency

* ts rlp

* change type location

* more types

* build types during regular build

* fix tests

* VSN -- [root] Changeset

* Merge remote-tracking branch 'origin/master' into nialexsan/add-types

* Revert "Resolve circular dependency"

This reverts commit 36efc7d.

* update lock

* VSN -- [root] changeset

* Implement typescript for several branches & adjust configuration (#1750)

Implements typescript support for: @onflow/rlp, @onflow/util-uid, @onflow/util-template, @onflow/util-logger, @onflow/util-invariant, @onflow/util-encode-key, @onflow/util-address

* Convert @onflow/types to TS (#1760)

* [WIP] Convert @onflow/types to TS

* stash

* kind of working

* fix package.json

* fix dictionary

* fix tests

* stash

* strong type tests

* remove any

* rename

* changeset

* PKG -- [util-actor] Enhance TS support (#1761)

* PKG -- [util-actor] Enhance TS support

* rename handlerfnmap

* PKG -- [types] Simplify generics for @onflow/types (#1772)

* PKG -- [types] Simplify generics

* Fix array

* Fix Array

* PKG -- [config] Convert @onflow/config to TS (#1731)

* PKG -- [config] Add TypeScript

* Changeset

* fixup

* Remove unnecessary generic from util-actor

* remove non null assertions

---------

Co-authored-by: Alex <[email protected]>

* Fix JSDoc type generation (#1780)

* restore changeset

* align packages

* pre typescript

* any type for config

* update package lock

* Update packages/util-logger/src/util-logger.ts

* fix config type

* use any type

* exit pre

* revert changes to changelogs

---------

Co-authored-by: Jordan Ribbink <[email protected]>
nialexsan added a commit that referenced this pull request Nov 29, 2023
* Nialexsan/add types (#1710)

* switch to uuid from @onflow/utils-uid

* create tsconfigs

* typedefs in ts

* types for actor util

* types for address util

* Revert "switch to uuid from @onflow/utils-uid"

This reverts commit 2a15ef5.

* PKG -- [util-actor] converted to ts

* updated tsconfig

* fixed ts types generation

* Resolve circular dependency

* ts rlp

* change type location

* more types

* build types during regular build

* fix tests

* VSN -- [root] Changeset

* Merge remote-tracking branch 'origin/master' into nialexsan/add-types

* Revert "Resolve circular dependency"

This reverts commit 36efc7d.

* update lock

* VSN -- [root] changeset

* Implement typescript for several branches & adjust configuration (#1750)

Implements typescript support for: @onflow/rlp, @onflow/util-uid, @onflow/util-template, @onflow/util-logger, @onflow/util-invariant, @onflow/util-encode-key, @onflow/util-address

* Convert @onflow/types to TS (#1760)

* [WIP] Convert @onflow/types to TS

* stash

* kind of working

* fix package.json

* fix dictionary

* fix tests

* stash

* strong type tests

* remove any

* rename

* changeset

* PKG -- [util-actor] Enhance TS support (#1761)

* PKG -- [util-actor] Enhance TS support

* rename handlerfnmap

* PKG -- [types] Simplify generics for @onflow/types (#1772)

* PKG -- [types] Simplify generics

* Fix array

* Fix Array

* PKG -- [config] Convert @onflow/config to TS (#1731)

* PKG -- [config] Add TypeScript

* Changeset

* fixup

* Remove unnecessary generic from util-actor

* remove non null assertions

---------

Co-authored-by: Alex <[email protected]>

* Fix JSDoc type generation (#1780)

* restore changeset

* align packages

* pre typescript

* any type for config

* update package lock

* PKG -- [util-encode-key] eslint ts config

* more ts

* move interaction types

* fix types

* more types

* authz types

* fix export

* fix imports

* fixed tests

* fix paths

* fix path

* fix some tests

* clean console log

* fix logic

* addressing PR comments

* fix build arguments

* shallow copy acct

* convert encode

* fix references

* revert changes

* ts resolve signature

* fix resolve accounts and interaction types

* fixed types

* fix path to interactions

* revert changes to changelogs

* fix types for resolve-accounts

* address comments

* changeset

* more descriptive names

* PKG -- [sdk] rename interfaces

* PKG -- [typedefs] fix merge conflict

* PKG -- [typedefs] fix merge conflicts

* PKG -- [sdk] fix interface imports

---------

Co-authored-by: Jordan Ribbink <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] @rollup/plugin-typescript doesn't recognize extends
2 participants