-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript Fixes #1750
Merged
Merged
Typescript Fixes #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 90abe42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nialexsan
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, great job!
nialexsan
pushed a commit
that referenced
this pull request
Nov 1, 2023
Implements typescript support for: @onflow/rlp, @onflow/util-uid, @onflow/util-template, @onflow/util-logger, @onflow/util-invariant, @onflow/util-encode-key, @onflow/util-address
nialexsan
added a commit
that referenced
this pull request
Nov 7, 2023
* Nialexsan/add types (#1710) * switch to uuid from @onflow/utils-uid * create tsconfigs * typedefs in ts * types for actor util * types for address util * Revert "switch to uuid from @onflow/utils-uid" This reverts commit 2a15ef5. * PKG -- [util-actor] converted to ts * updated tsconfig * fixed ts types generation * Resolve circular dependency * ts rlp * change type location * more types * build types during regular build * fix tests * VSN -- [root] Changeset * Merge remote-tracking branch 'origin/master' into nialexsan/add-types * Revert "Resolve circular dependency" This reverts commit 36efc7d. * update lock * VSN -- [root] changeset * Implement typescript for several branches & adjust configuration (#1750) Implements typescript support for: @onflow/rlp, @onflow/util-uid, @onflow/util-template, @onflow/util-logger, @onflow/util-invariant, @onflow/util-encode-key, @onflow/util-address * Convert @onflow/types to TS (#1760) * [WIP] Convert @onflow/types to TS * stash * kind of working * fix package.json * fix dictionary * fix tests * stash * strong type tests * remove any * rename * changeset * PKG -- [util-actor] Enhance TS support (#1761) * PKG -- [util-actor] Enhance TS support * rename handlerfnmap * PKG -- [types] Simplify generics for @onflow/types (#1772) * PKG -- [types] Simplify generics * Fix array * Fix Array * PKG -- [config] Convert @onflow/config to TS (#1731) * PKG -- [config] Add TypeScript * Changeset * fixup * Remove unnecessary generic from util-actor * remove non null assertions --------- Co-authored-by: Alex <[email protected]> * Fix JSDoc type generation (#1780) * restore changeset * align packages * pre typescript * any type for config * update package lock * Update packages/util-logger/src/util-logger.ts * fix config type * use any type * exit pre * revert changes to changelogs --------- Co-authored-by: Jordan Ribbink <[email protected]>
nialexsan
added a commit
that referenced
this pull request
Nov 29, 2023
* Nialexsan/add types (#1710) * switch to uuid from @onflow/utils-uid * create tsconfigs * typedefs in ts * types for actor util * types for address util * Revert "switch to uuid from @onflow/utils-uid" This reverts commit 2a15ef5. * PKG -- [util-actor] converted to ts * updated tsconfig * fixed ts types generation * Resolve circular dependency * ts rlp * change type location * more types * build types during regular build * fix tests * VSN -- [root] Changeset * Merge remote-tracking branch 'origin/master' into nialexsan/add-types * Revert "Resolve circular dependency" This reverts commit 36efc7d. * update lock * VSN -- [root] changeset * Implement typescript for several branches & adjust configuration (#1750) Implements typescript support for: @onflow/rlp, @onflow/util-uid, @onflow/util-template, @onflow/util-logger, @onflow/util-invariant, @onflow/util-encode-key, @onflow/util-address * Convert @onflow/types to TS (#1760) * [WIP] Convert @onflow/types to TS * stash * kind of working * fix package.json * fix dictionary * fix tests * stash * strong type tests * remove any * rename * changeset * PKG -- [util-actor] Enhance TS support (#1761) * PKG -- [util-actor] Enhance TS support * rename handlerfnmap * PKG -- [types] Simplify generics for @onflow/types (#1772) * PKG -- [types] Simplify generics * Fix array * Fix Array * PKG -- [config] Convert @onflow/config to TS (#1731) * PKG -- [config] Add TypeScript * Changeset * fixup * Remove unnecessary generic from util-actor * remove non null assertions --------- Co-authored-by: Alex <[email protected]> * Fix JSDoc type generation (#1780) * restore changeset * align packages * pre typescript * any type for config * update package lock * PKG -- [util-encode-key] eslint ts config * more ts * move interaction types * fix types * more types * authz types * fix export * fix imports * fixed tests * fix paths * fix path * fix some tests * clean console log * fix logic * addressing PR comments * fix build arguments * shallow copy acct * convert encode * fix references * revert changes * ts resolve signature * fix resolve accounts and interaction types * fixed types * fix path to interactions * revert changes to changelogs * fix types for resolve-accounts * address comments * changeset * more descriptive names * PKG -- [sdk] rename interfaces * PKG -- [typedefs] fix merge conflict * PKG -- [typedefs] fix merge conflicts * PKG -- [sdk] fix interface imports --------- Co-authored-by: Jordan Ribbink <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
"types"
key in package.json files (strict mode found these)Packages whose conversion this completes:
closes #1745. @onflow/rlp
closes #1744. @onflow/util-uid
closes #1743. @onflow/util-template
closes #1741. @onflow/util-logger
closes #1740. @onflow/util-invariant
closes #1739. @onflow/util-encode-key
closes #1738. @onflow/util-address