Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dev command #1831

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

remove dev command #1831

wants to merge 2 commits into from

Conversation

nialexsan
Copy link
Contributor

Closes #1794

Description

Remove dev command

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.07%. Comparing base (308f7f1) to head (d1636f9).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1831      +/-   ##
==========================================
+ Coverage   27.90%   29.07%   +1.17%     
==========================================
  Files          95       93       -2     
  Lines        6482     6221     -261     
==========================================
  Hits         1809     1809              
+ Misses       4497     4236     -261     
  Partials      176      176
Flag Coverage Δ
unittests 29.07% <ø> (+1.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nialexsan nialexsan mentioned this pull request Nov 20, 2024
Open
2 tasks
@nialexsan nialexsan marked this pull request as ready for review November 29, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kay-Zee Kay-Zee Awaiting requested review from Kay-Zee Kay-Zee is a code owner

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik is a code owner

@chasefleming chasefleming Awaiting requested review from chasefleming chasefleming is a code owner

@nvdtf nvdtf Awaiting requested review from nvdtf nvdtf is a code owner

@bluesign bluesign Awaiting requested review from bluesign bluesign is a code owner

@bjartek bjartek Awaiting requested review from bjartek bjartek is a code owner

@jribbink jribbink Awaiting requested review from jribbink jribbink is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
🌊 Flow 4D
Status: 👀 In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove flow dev
2 participants
@nialexsan @codecov-commenter