Report system chunk transactions within a block

[m-Peter]

Closes #911

Description

The last transaction returned from flow.GetTransactionsByBlockID, is the system chunk transaction. We add it as the last transaction in the last collection, so it can be returned from the command:

flow blocks get 53665542 --network=mainnet --include transactions

---

For contributor use:

• Targeted PR against master branch
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work
• Code follows the standards mentioned here
• Updated relevant documentation
• Re-reviewed Files changed in the Github PR explorer
• Added appropriate labels

[codecov-commenter]

Codecov Report

Merging #1091 (79f9aa3) into master (6c48d41) will increase coverage by 0.01%.
The diff coverage is 41.66%.

@@            Coverage Diff             @@
##           master    #1091      +/-   ##
==========================================
+ Coverage   39.50%   39.51%   +0.01%     
==========================================
  Files          37       37              
  Lines        1858     1870      +12     
==========================================
+ Hits          734      739       +5     
- Misses       1039     1044       +5     
- Partials       85       87       +2     

Flag	Coverage Δ
unittests	39.51% <41.66%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
internal/blocks/get.go	65.90% <41.66%> (-9.10%)	⬇️

[janezpodhostnik]

The solution looks good, but it is a strange problem to have in the first place.

Does flow.GetBlock not return the system collection?

[m-Peter]

@janezpodhostnik It seems that none of the returned collections contain the system chunk transaction. I am not sure if this is supposed to be included in a system collection, with only the system chunk transaction. I have tagged you in the relevant thread on discord: https://discord.com/channels/613813861610684416/1108968095982293002/1118596780444094525 🙏 Hope it clarifies things 🙇