Add pins to dependency height #2246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
jribbink
force-pushed
the
jribbink/height-pins
branch
from
ade9dab to
3595078
Compare
jribbink
force-pushed
the
jribbink/height-pins
branch
from
c1e9e21 to
941d475
Compare
jribbink
requested review from
Kay-Zee,
bjartek,
chasefleming,
janezpodhostnik,
mfbz and
nvdtf
as code owners
There was a problem hiding this comment.
Pull request overview
This PR adds block height pinning to Flow dependency manager, enabling reproducible dependency installation across machines and CI environments. Dependencies are now frozen to specific blockchain block heights, ensuring consistent contract versions.
Key changes:
- Block height tracking for each dependency with automatic pinning on install
- Historical contract retrieval using
GetAccountAtBlockHeightfor pinned versions - Backward-compatible migration (zero block heights auto-migrate to latest)
- Spork recovery logic to handle inaccessible historical blocks
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
internal/dependencymanager/dependencyinstaller.go |
Implements block height caching, historical contract fetching, spork recovery, and cross-network duplicate detection |
internal/dependencymanager/dependencyinstaller_test.go |
Comprehensive test coverage for block height pinning scenarios including new dependencies, migrations, spork recovery, and caching |
go.mod |
Updates flowkit dependency and promotes flow-core-contracts to direct dependency |
flowkit/schema.json |
Adds block_height and canonical fields to JSON schema for dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jribbink
added
the
Improvement
chasefleming
approved these changes
Jan 8, 2026
chasefleming
reviewed
Jan 8, 2026
chasefleming
reviewed
Jan 8, 2026
chasefleming
reviewed
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2243
Description
Adds
block_heightpins to DM dependencies.block_heightpins will be added after the first install after updating.flow.jsonis still backward-compatible with old CLI version, and will just ignore the unknown fieldFor contributor use:
masterbranchFiles changedin the Github PR explorer