Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require proof of possession of the staking private key from staking nodes #426

Open
tarakby opened this issue May 7, 2024 · 0 comments
Open

Comments

@tarakby
Copy link
Contributor

tarakby commented May 7, 2024

Context

(based on the old private repo issue https://github.com/dapperlabs/flow-go/issues/6284)

Proof of possession of the staking private key (PoP) is a required info from all staking nodes, to prevent BLS rogue key attacks.
This issue is about updating the core contract node registration to require a valid PoP in all staking requests.

Definition of Done

  • Add a new proof of possession parameter to the registerNode method
  • Verify the PoP in the register method, if it doesn't verify properly, revert
  • Update LockedTokens and StakingCollection to use this new parameter also
  • Add tests for the transaction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant