Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use service account Admin resource to set weights #432

Open
joshuahannan opened this issue May 16, 2024 · 0 comments
Open

Use service account Admin resource to set weights #432

joshuahannan opened this issue May 16, 2024 · 0 comments
Assignees
Labels
Feature Feedback good first issue Good for newcomers Improvement SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board Technical Debt

Comments

@joshuahannan
Copy link
Member

Issue To Be Solved

Currently, the transactions to update weights for fees just save values directly to storage. These should be resource functions with proper input validation.

Suggest A Solution

Add functions with input validaton to FlowServiceAccount.Administrator to:

Write tests to ensure the functions work and the input validation works

@joshuahannan joshuahannan added good first issue Good for newcomers Feedback Feature Improvement Technical Debt SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board labels May 16, 2024
@joshuahannan joshuahannan moved this to 🧊 Backlog in 🌊 Flow 4D May 16, 2024
@joshuahannan joshuahannan self-assigned this Sep 26, 2024
@joshuahannan joshuahannan moved this from 🧊 Backlog to 🔖 Ready for Pickup in 🌊 Flow 4D Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feedback good first issue Good for newcomers Improvement SC-Eng Issues that we want to see surfaced in SC-Eng ZH Board Technical Debt
Projects
Status: 🔖 Ready for Pickup
Development

No branches or pull requests

1 participant