Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BFT] Add Staking Key PoP to bootstrapping tools #2803

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

[BFT] Add Staking Key PoP to bootstrapping tools #2803

wants to merge 15 commits into from

Conversation

tarakby
Copy link
Contributor

@tarakby tarakby commented Jul 14, 2022 •
edited
Loading

Addresses https://github.com/dapperlabs/flow-go/issues/6286

PoP refers to the Proof of Possession of the staking private key. Requiring a PoP is necessary to secure BLS aggregation and SPoCK in the protocol.

This PR includes PoP generation/validation in the bootstrapping command tool:

  • Key generation command now generates and outputs the PoP.
  • The PoP is part of the public node info, it is written in the public info files when bootstrapping the network data.
  • Validation of staking public key now includes staking PoP validation.

@tarakby tarakby changed the title Tarak/6286 spork tool pop [BFT] Add Staking Key PoP to bootstrapping tools. Jul 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2022 •
edited
Loading

Codecov Report

Attention: Patch coverage is 14.96599% with 125 lines in your changes are missing coverage. Please review.

Project coverage is 55.59%. Comparing base (957437f) to head (3cf9e32).
Report is 30 commits behind head on master.

Files Patch % Lines
cmd/bootstrap/cmd/final_list.go 0.00% 32 Missing ⚠️
utils/unittest/fixtures.go 0.00% 28 Missing ⚠️
model/bootstrap/node_info.go 26.47% 24 Missing and 1 partial ⚠️
cmd/bootstrap/cmd/keygen.go 0.00% 10 Missing ⚠️
integration/testnet/container.go 0.00% 5 Missing ⚠️
integration/testnet/network.go 16.66% 4 Missing and 1 partial ⚠️
cmd/bootstrap/cmd/partner_infos.go 0.00% 4 Missing ⚠️
cmd/bootstrap/utils/node_info.go 0.00% 4 Missing ⚠️
integration/testnet/util.go 0.00% 3 Missing ⚠️
cmd/bootstrap/cmd/key.go 50.00% 1 Missing and 1 partial ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2803      +/-   ##
==========================================
+ Coverage   55.49%   55.59%   +0.09%     
==========================================
  Files        1133     1134       +1     
  Lines       89496    89711     +215     
==========================================
+ Hits        49662    49871     +209     
+ Misses      35062    35044      -18     
- Partials     4772     4796      +24
Flag Coverage Δ
unittests 55.59% <14.96%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarakby tarakby changed the title [BFT] Add Staking Key PoP to bootstrapping tools. [BFT] Add Staking Key PoP to bootstrapping tools May 9, 2024
@tarakby tarakby self-assigned this May 9, 2024
@tarakby tarakby added the S-BFT label May 9, 2024
@github-actions github-actions bot added the Stale Label used when marking an issue stale. label Sep 28, 2024
@github-actions github-actions bot closed this Oct 8, 2024
@tarakby tarakby reopened this Oct 8, 2024
@tarakby tarakby removed the Stale Label used when marking an issue stale. label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangchiqing zhangchiqing Awaiting requested review from zhangchiqing zhangchiqing will be requested when the pull request is marked ready for review zhangchiqing is a code owner

@AlexHentschel AlexHentschel Awaiting requested review from AlexHentschel AlexHentschel will be requested when the pull request is marked ready for review AlexHentschel is a code owner

@durkmurder durkmurder Awaiting requested review from durkmurder durkmurder will be requested when the pull request is marked ready for review durkmurder is a code owner

@jordanschalm jordanschalm Awaiting requested review from jordanschalm jordanschalm will be requested when the pull request is marked ready for review jordanschalm is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@tarakby tarakby

Labels
S-BFT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarakby @codecov-commenter