Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable Cadence preview release support #224

Closed
sisyphusSmiling opened this issue Sep 29, 2023 · 3 comments · Fixed by #225
Closed

Stable Cadence preview release support #224

sisyphusSmiling opened this issue Sep 29, 2023 · 3 comments · Fixed by #225
Assignees

Comments

@sisyphusSmiling
Copy link
Contributor

Description

With the Stable Cadence milestone approaching (Cadence 1.0) and preview releases of Flow CLI, emulator, flow-go SDK, etc. enabling devs to compose next version Cadence code, developers will need to be able to test their updated implementations using existing tests.

Suggestion

This testing framework is often used across many Flow projects, including standard and core repos - flow-nft, nft-storefront, flow-core-contracts to name a few. It would be very helpful to run the same tests passing with a current Cadence version against an updated Cadence 1.0 implementation using a flow-js-testing pre-release.

Context

Working on stable cadence updates to the NFTStorefront contracts and will continue to update contracts moving forward.

@NtTestAlert
Copy link
Contributor

Working on it. Planning on posting a PR tomorrow.
(Currently mocking it with jest internally, will copy over changes upstream)

@jribbink
Copy link
Contributor

jribbink commented Mar 25, 2024

We will also need to setup a release process/separate branch/CI actions for this functionality. I will create a feature/stable-cadence branch which releases to @onflow/flow-js-testing@stable-cadence.

@jribbink
Copy link
Contributor

jribbink commented Apr 7, 2024

@onflow/[email protected] has all of the latest Cadence 1.0 changes

@jribbink jribbink closed this as completed Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants