Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue parsing the version number #233

Closed
Luze26 opened this issue May 23, 2024 · 3 comments · Fixed by #235
Closed

Issue parsing the version number #233

Luze26 opened this issue May 23, 2024 · 3 comments · Fixed by #235
Labels
bug Something isn't working

Comments

@Luze26
Copy link

Luze26 commented May 23, 2024

When having the last Flow CLI version installed and using flow-js-testing 0.6.0-stable-cadence.3.
The emulator failed to start (when doing emulator.start()) due to the fact the code was not able to parse the CLI version response.

const versionStr = JSON.parse(stdout).version

stdout is not a json, The CLI returns something like that with my version:

Version: v1.15.0-cadence-v1.0.0-preview.13
Commit: 8b6842e043a011cd8b3bb2f43e6e75cd17b713c3

I'll try to do a PR when I have time.

@Luze26 Luze26 added the bug Something isn't working label May 23, 2024
@Luze26 Luze26 mentioned this issue May 23, 2024
6 tasks
@Luze26
Copy link
Author

Luze26 commented May 23, 2024

I tried to do a PR here #235 .
Sorry if I didn't respect some standards or rules, I'm not used to do PRs on open source repo.
Also I was not able to run tests locally.

@jribbink
Copy link
Contributor

Awesome thanks for your contribution @Luze26, if you update to the latest Cadence 1.0 CLI Version, this issue will be resolved (JSON version output is a somewhat new feature) but I can still look at the PR for backward-compatibility reasons.

(I'd recommend updating your Cadence 1.0 CLI regardless, as only the latest CLI versions have the latest features/changes)

@Luze26
Copy link
Author

Luze26 commented May 23, 2024

oh ok thanks, I thought I was on the latest version.

@jribbink jribbink linked a pull request May 23, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants