Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] provide guidance on MetadataViews in HybridCustody #92

Open
sisyphusSmiling opened this issue Jun 20, 2023 · 0 comments
Open

[DOCS] provide guidance on MetadataViews in HybridCustody #92

sisyphusSmiling opened this issue Jun 20, 2023 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@sisyphusSmiling
Copy link
Collaborator

Related: #16

It was noted in the audit report that it was not possible to update ProxyAccount.display as the parent account since ProxyAccount.setDisplay() is access(contract). However, this functionality is enabled by Manager.setChildDisplay().

This misconception highlights the need for better documentation on this fact. Any documentation should cover the displays for both ChildAccount and ProxyAccount, who can change each, when in the linking process each should be set, which resource to rely on as source of truth, and how to resolve this.

Other topics to note might include warning about phishing vectors, and how to add additional view types via data buckets.

@sisyphusSmiling sisyphusSmiling added the documentation Improvements or additions to documentation label Jun 20, 2023
@sisyphusSmiling sisyphusSmiling self-assigned this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant