Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pragma #9

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Add pragma #9

merged 3 commits into from
Mar 14, 2023

Conversation

sisyphusSmiling
Copy link
Collaborator

@sisyphusSmiling sisyphusSmiling commented Mar 13, 2023

Closes: #7

Relevant: onflow/cadence#2353 & onflow/cadence#2380

Description

Cadence recently introduced an account linking pragma #allowAccountLinking as an interim security measure. Currently, the pragma check is done statically, and must be stated statically in the contract in which linkAccount() is called. This means that the ChildAccount contract is currently broken on Testnet.

This PR adds the account linking pragma to ChildAccount contract and account linking transactions to enable AuthAccount.linkAccount().


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling sisyphusSmiling added the bug Something isn't working label Mar 13, 2023
@sisyphusSmiling sisyphusSmiling self-assigned this Mar 13, 2023
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review March 13, 2023 16:31
@sisyphusSmiling sisyphusSmiling merged commit aa25b12 into main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add #allowAccountLinking pragma to linking transactions
3 participants