Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add startup notifications defined by remote GH source #502

Merged
merged 10 commits into from
Feb 10, 2024
Merged

Add startup notifications defined by remote GH source #502

merged 10 commits into from
Feb 10, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Jan 6, 2024 •
edited
Loading

Closes #501

Description

Adds remote notifications from the GH master branch & displays these at startup.

Adds Cadence 1.0 Notificaiton

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink marked this pull request as draft January 6, 2024 00:22
@jribbink jribbink marked this pull request as ready for review January 26, 2024 18:57
@jribbink jribbink added the feature A new user feature or a new package API label Jan 26, 2024
@jribbink jribbink requested a review from nialexsan January 26, 2024 18:58
nialexsan
nialexsan approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@nialexsan nialexsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm👨‍🍳

@jribbink jribbink merged commit 4dcf98d into master Feb 10, 2024
1 of 6 checks passed
@jribbink jribbink deleted the jribbink/remote-notify branch February 10, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nialexsan nialexsan nialexsan approved these changes

Assignees
No one assigned
Labels
feature A new user feature or a new package API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add remote notifications at extension startup (Cadence 1.0)
2 participants
@jribbink @nialexsan