Skip to content
This repository has been archived by the owner on Feb 13, 2018. It is now read-only.

"Allow" usage of !!. #1

Open
nning opened this issue Mar 21, 2014 · 1 comment
Open

"Allow" usage of !!. #1

nning opened this issue Mar 21, 2014 · 1 comment

Comments

@nning
Copy link

nning commented Mar 21, 2014

The current (freshly forked) version of the style guide states "Avoid the use of !!.". The bad examples there are for nil checks and on booleans. I would tend to allow it for "casting into booleans to return only boolean" as in...

def display_commit?
  !! Settings.display_head_commit
end

But I would presume, not to use a space between "!!" and the following term to be consistent with the "No space after !." rule.

@0robustus1
Copy link

Somewhat part of pull-request #4. Maybe needs further discussion?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants