Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single newlines are no longer possible in chat after release 2.0 #6597

Open
1 task done
mamei16 opened this issue Dec 21, 2024 · 3 comments
Open
1 task done

Single newlines are no longer possible in chat after release 2.0 #6597

mamei16 opened this issue Dec 21, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@mamei16
Copy link
Contributor

mamei16 commented Dec 21, 2024

Describe the bug

After release 2.0 (which looks nice btw), single newlines are no longer displayed as such. The following illustrates how it was before:

Line 1
Line 2

And this how it looks now:

Line 1 Line 2

It seems the only type of newlines that are displayed are double newlines like:

Line1

Line2

This is probably caused by the changes made in modules/html_generator.py. Pls fix, the status messages of my extension look weird now.

Is there an existing issue for this?

  • I have searched the existing issues

Reproduction

As a user:

  1. Try to include a single newline in your message to the LLM (without an empty line)
  2. Fail

As an extension developer:

  1. Try to append some text, which is supposed to be displayed on a new line, to the LLM's output (like llm_output + "\nMy cool message on a new line")
  2. Fail

Screenshot

No response

Logs

none

System Info

conputer
@mamei16 mamei16 added the bug Something isn't working label Dec 21, 2024
@oobabooga
Copy link
Owner

oobabooga commented Dec 22, 2024

This was the only change to newline behavior

3d19746

It was done to fix lists like

# Main List

- Item 1
  - Subitem 1.1
  - Subitem 1.2
    - Sub-subitem 1.2.1
    - Sub-subitem 1.2.2
- Item 2
  - Subitem 2.1
  - Subitem 2.2
- Item 3

Can you send a PR if you find the issue?

@dEATh-PM
Copy link

As I have observed the same thing, tried reproducing the double to single newline using just that for loop and couldn't.

I did however find it will turn a double into a triple newline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants
@mamei16 @oobabooga @dEATh-PM and others