Refactored the code as suggested in review comments

Author: oops-shlok

src/main/java/org/jabref/gui/WelcomeTab.java

@@ -153,18 +153,12 @@ private VBox createWelcomeRecentBox() {
     }
 
     private void updateWelcomeRecentLibraries() {
-        recentLibrariesBox.getChildren().clear();
-
         if (fileHistoryMenu.getItems().isEmpty()) {
-            Label noRecentLibrariesLabel = new Label(Localization.lang("No recent libraries"));
-            noRecentLibrariesLabel.getStyleClass().add("welcome-no-recent-label");
-            recentLibrariesBox.getChildren().add(noRecentLibrariesLabel);
-
-            fileHistoryMenu.disableProperty().unbind();
-            fileHistoryMenu.setDisable(true);
+            displayNoRecentLibrariesMessage();
             return;
         }
 
+        recentLibrariesBox.getChildren().clear();
         fileHistoryMenu.disableProperty().unbind();
         fileHistoryMenu.setDisable(false);
 
@@ -176,6 +170,16 @@ private void updateWelcomeRecentLibraries() {
         }
     }
 
+    private void displayNoRecentLibrariesMessage() {
+        recentLibrariesBox.getChildren().clear();
+        Label noRecentLibrariesLabel = new Label(Localization.lang("No recent libraries"));
+        noRecentLibrariesLabel.getStyleClass().add("welcome-no-recent-label");
+        recentLibrariesBox.getChildren().add(noRecentLibrariesLabel);
+
+        fileHistoryMenu.disableProperty().unbind();
+        fileHistoryMenu.setDisable(true);
+    }
+
     private VBox createVBoxContainer(Node... nodes) {
         VBox box = new VBox(5);
         box.setAlignment(Pos.TOP_LEFT);

src/main/java/org/jabref/gui/exporter/ExportCommand.java

@@ -133,23 +133,19 @@ private void export(Path file, FileChooser.ExtensionFilter selectedExtensionFilt
                     return null; // can not use BackgroundTask.wrap(Runnable) because Runnable.run() can't throw Exceptions
                 })
                 .onSuccess(save -> {
-                    boolean currentTabIsLibraryTab = tabSupplier.get() != null;
-                    // libraryTab is null in case of Welcome Tab
-                    if (currentTabIsLibraryTab) {
-                        LibraryTab.DatabaseNotification notificationPane = tabSupplier.get().getNotificationPane();
-                        notificationPane.notify(
-                                IconTheme.JabRefIcons.FOLDER.getGraphicNode(),
-                                Localization.lang("Export operation finished successfully."),
-                                List.of(new Action(Localization.lang("Reveal in File Explorer"), event -> {
-                                    try {
-                                        NativeDesktop.openFolderAndSelectFile(file, preferences.getExternalApplicationsPreferences(), dialogService);
-                                    } catch (IOException e) {
-                                        LOGGER.error("Could not open export folder.", e);
-                                    }
-                                    notificationPane.hide();
-                                })),
-                                Duration.seconds(5));
-                    }
+                    LibraryTab.DatabaseNotification notificationPane = tabSupplier.get().getNotificationPane();
+                    notificationPane.notify(
+                            IconTheme.JabRefIcons.FOLDER.getGraphicNode(),
+                            Localization.lang("Export operation finished successfully."),
+                            List.of(new Action(Localization.lang("Reveal in File Explorer"), event -> {
+                                try {
+                                    NativeDesktop.openFolderAndSelectFile(file, preferences.getExternalApplicationsPreferences(), dialogService);
+                                } catch (IOException e) {
+                                    LOGGER.error("Could not open export folder.", e);
+                                }
+                                notificationPane.hide();
+                            })),
+                            Duration.seconds(5));
                 })
                 .onFailure(this::handleError)
                 .executeWith(taskExecutor);