Merge branch 'main' of https://github.com/JabRef/jabref into fix-for-issue-JabRef#12272

Author: oops-shlok

.gitattributes

@@ -13,3 +13,4 @@ gradlew text eol=lf
 *.properties text eol=lf
 
 CHANGELOG.md merge=union
+src/main/resources/l10n/JabRef_en.properties merge=union

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,21 +1,27 @@
-<!-- YOU HAVE TO MODIFY THIS TEXT TO FIT YOUR PR. OTHERWISE, YOUR PR WILL BE CLOSED WITHOUT FURTHER COMMENT. -->
-
-Describe the changes you have made here: what, why, ...
+<!-- YOU HAVE TO MODIFY THE TEXT BELOW TO FIT YOUR PR. OTHERWISE, YOUR PR WILL BE CLOSED WITHOUT FURTHER COMMENT. -->
 
 <!-- LINK THE ISSUE WITH THE "Closes" KEYWORD -->
-<!-- Example: Closes (link) OR Closes #xyz -->
+<!-- Example: Closes (link) OR Closes #12345 -->
+
+Closes _____
+Describe the changes you have made here: what, where, why, ...
+If your work is not yet complete, please open a draft pull request. In that case, outline your intended next steps. Do you need feedback? Will you continue in parallel? ...
 
 ### Mandatory checks
 
 <!--
-- Go through the list below. Please don't remove any items.
-- [x] done; [ ] not done / not applicable
+Go throgh the checklist below. It is mandatory, even for a draft pull request.
+
+Keep ALL the items. Mark them as follows: 
+[x] done 
+[ ] not done 
+[/] not applicable
 -->
 
 - [x] I own the copyright of the code submitted and I licence it under the [MIT license](https://github.com/JabRef/jabref/blob/main/LICENSE)
 - [ ] Change in `CHANGELOG.md` described in a way that is understandable for the average user (if change is visible to the user)
 - [ ] Tests created for changes (if applicable)
 - [ ] Manually tested changed features in running JabRef (always required)
-- [ ] Screenshots added in PR description (for UI changes)
+- [ ] Screenshots added in PR description (if change is visible to the user)
 - [ ] [Checked developer's documentation](https://devdocs.jabref.org/): Is the information available and up to date? If not, I outlined it in this pull request.
 - [ ] [Checked documentation](https://docs.jabref.org/): Is the information available and up to date? If not, I created an issue at <https://github.com/JabRef/user-documentation/issues> or, even better, I submitted a pull request to the documentation repository.

.github/ghprcomment.yml

@@ -5,6 +5,7 @@
     Please carefully follow [the setup guide for the codestyle](https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace/intellij-13-code-style.html).
     Afterwards, please [run checkstyle locally](https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace/intellij-13-code-style.html#run-checkstyle) and fix the issues.
 
+
     In case of issues with the import order, double check that you [activated Auto Import](https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace/intellij-13-code-style.html#enable-proper-import-cleanup).
     You can trigger fixing imports by pressing <kbd>Ctrl</kbd>+<kbd>Alt</kbd>+<kbd>O</kbd> to trigger [Optimize Imports](https://www.jetbrains.com/guide/tips/optimize-imports/).
 - jobName: OpenRewrite
@@ -14,20 +15,23 @@
     The issues found can be **automatically fixed**.
     Please execute the gradle task *`rewriteRun`*, check the results, commit, and push.
 
+
     You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "OpenRewrite".
 - jobName: Modernizer
   message: >
     Your code currently does not meet JabRef's code guidelines.
     We use [Gradle Modernizer Plugin](https://github.com/andygoossens/gradle-modernizer-plugin#gradle-modernizer-plugin) to ensure "modern" Java coding practices.
     Please fix the detected errors, commit, and push.
 
+
     You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "Modernizer".
 - jobName: Markdown
   message: >
     You modified Markdown (`*.md`) files and did not meet JabRef's rules for consistently formatted Markdown files.
     To ensure consistent styling, we have [markdown-lint](https://github.com/DavidAnson/markdownlint) in place.
     [Markdown lint's rules](https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#rules) help to keep our Markdown files consistent within this repository and consistent with the Markdown files outside here.
 
+
     You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "Markdown".
 - jobName: CHANGELOG.md
   message: |
@@ -39,17 +43,16 @@
     In the area "Some checks were not successful", locate "Tests / Unit tests (pull_request)" and click on "Details".
     This brings you to the test output.
 
+
     You can then run these tests in IntelliJ to reproduce the failing tests locally.
     We offer a quick test running howto in the section [Final build system checks](https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace/intellij-12-build.html#final-build-system-checks) in our setup guide.
 - jobName: no-force-push
   message: >
     Do not force-push!
-    Force push is off limits and very bad style when working together on a project.
-    ([Mainly because it is not supported well by GitHub istself.](https://github.com/orgs/community/discussions/3478))
-    Commits will be lost, comments on commits will loose their context.
-    This makes it harder to review.
-    In the end, all commits will be [squashed](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges#squash-and-merge-your-commits) either way before being merged into the `main`` branch.
-- jobName: move_issue
+    Force pushing is a very bad practice when working together on a project (mainly because it is [not supported well by GitHub itself](https://github.com/orgs/community/discussions/3478)).
+    Commits are lost and comments on commits lose their context, thus making it harder to review changes.
+    At the end, all commits will be [squashed](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges#squash-and-merge-your-commits) anyway before being merged into the `main` branch.
+- jobName: 'Mark issue as in progress'
   message: |
     Your pull request needs to link an issue.
 
@@ -81,3 +84,16 @@
     - ✅ `Fixes https://github.com/JabRef/jabref/issues/xyz` links pull-request to issue. Merging the PR will close the issue.
     - ✅ `Fixes https://github.com/Koppor/jabref/issues/xyz` links pull-request to issue. Merging the PR will close the issue.
     - ❌ `Fixes [#xyz](https://github.com/JabRef/jabref/issues/xyz)` links pull-request to issue. Merging the PR will **NOT** close the issue.
+- jobName: 'Conflicts with target branch'
+  message: >
+    Your pull request conflicts with the target branch.
+
+
+    Please [merge `upstream/main`](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork#syncing-a-fork-branch-from-the-command-line) with your code.
+    For a step-by-step guide to resolve merge conflicts, see <https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line>.
+- jobName: 'Submodules not modified'
+  message: >
+    Your pull request modified git submodules.
+
+
+    Please follow our [FAQ on submodules](https://devdocs.jabref.org/code-howtos/faq.html#submodules) to fix.

.github/workflows/check-links.yml

@@ -1,14 +1,11 @@
 name: Check external href links in the documentation
 
 on:
-  push:
+  pull_request:
     paths:
       - '.github/workflows/check-links.yml'
-      - '.lycheeignore'
-      - 'lychee.toml'
+      - '.linkspector.yml'
       - '**/*.md'
-    paths-ignore:
-      - 'CHANGELOG.md'
   schedule:
     # Run on the first of each month at 9:00 AM (See https://pubs.opengroup.org/onlinepubs/9699919799/utilities/crontab.html#tag_20_25_07)
     - cron: "0 9 1 * *"
@@ -19,22 +16,16 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  lychee:
-    if: github.repository_owner == 'JabRef'
+  check-links:
+    if: github.repository == 'JabRef/jabref'
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
         with:
           show-progress: 'false'
-      - name: Restore lychee cache
-        uses: actions/cache@v4
+      - name: Run linkspector
+        uses: umbrelladocs/action-linkspector@v1
         with:
-          path: .lycheecache
-          key: cache-lychee-${{ github.sha }}
-          restore-keys: cache-lychee-
-      - name: Link Checker
-        id: lychee
-        uses: lycheeverse/[email protected]
-        with:
-          fail: true
-          args: --accept '200,201,202,203,204,403,429,500' --max-concurrency 1 --cache --no-progress --exclude-all-private './**/*.md'
+          github_token: ${{ secrets.github_token }}
+          reporter: github-pr-review
+          fail_level: any

.github/workflows/delete-old-runs-automatically.yml

@@ -0,0 +1,18 @@
+name: Delete old workflow runs (automatically)
+on:
+  schedule:
+    - cron: '0 0 1 * *'
+jobs:
+  del_runs:
+    runs-on: ubuntu-latest
+    permissions:
+      actions: write
+      contents: read
+    steps:
+      - name: Delete workflow runs
+        uses: Mattraks/delete-workflow-runs@v2
+        with:
+          token: ${{ github.token }}
+          repository: ${{ github.repository }}
+          retain_days: 30
+          keep_minimum_runs: 6

.github/workflows/delete-old-runs.yml .github/workflows/delete-old-runs-manually.yml

@@ -1,4 +1,4 @@
-name: Delete old workflow runs
+name: Delete old workflow runs (manually)
 on:
   workflow_dispatch:
     inputs:

.github/workflows/deployment-arm64.yml

@@ -100,8 +100,6 @@ jobs:
           keychain-password: jabref
       - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v4
-        with:
-          gradle-home-cache-cleanup: true
       - name: Prepare merged jars and modules dir (macOS)
         run: ./gradlew -i -PprojVersion="${{ steps.gitversion.outputs.AssemblySemVer }}" -PprojVersionInfo="${{ steps.gitversion.outputs.InformationalVersion }}" prepareModulesDir
       - name: Build dmg (macOS)

.github/workflows/deployment-jdk-ea.yml

@@ -193,8 +193,6 @@ jobs:
           distribution: 'temurin'
       - name: Set up Gradle
         uses: gradle/actions/setup-gradle@v4
-        with:
-          gradle-home-cache-cleanup: true
       - name: Prepare merged jars and modules dir
         # prepareModulesDir is executing a build, which should run through even if no upload to builds.jabref.org is made
         if: (steps.checksecrets.outputs.secretspresent == 'NO')

.github/workflows/deployment.yml

@@ -94,8 +94,6 @@ jobs:
           distribution: 'temurin'
       - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v4
-        with:
-          gradle-home-cache-cleanup: true
       - name: Prepare merged jars and modules dir (macOS)
         # prepareModulesDir is executing a build, which should run through even if no upload to builds.jabref.org is made
         if: (matrix.os == 'macos-13') || (steps.checksecrets.outputs.secretspresent == 'NO')

.github/workflows/gource.yml

@@ -15,7 +15,7 @@ concurrency:
 
 jobs:
   action:
-    if: github.repository_owner == 'JabRef'
+    if: github.repository == 'JabRef/jabref'
     runs-on: ubuntu-latest
     steps:
       - name: 'Checkout'

.github/workflows/assign-issue.yml .github/workflows/on-issue-comment.yml

@@ -1,15 +1,12 @@
-name: Assign Issue
+name: On isuse comment
 
 on:
-  schedule:
-    - cron: 4 12 * * *
   issue_comment:
     types: [created]
-  workflow_dispatch:
 
 jobs:
   assign:
-    if: github.repository_owner == 'JabRef'
+    if: github.repository == 'JabRef/jabref'
     runs-on: ubuntu-latest
     permissions:
       issues: write
@@ -32,11 +29,14 @@ jobs:
 
             Happy coding! 🚀
 
-            ⏳ Please note, you will be automatically unassigned if the issue isn't closed within **{{ total_days }} days** (by **{{ unassigned_date }}**). A maintainer can also add the "**{{ pin_label }}**"" label to prevent automatic unassignment.
-      - name: Move Issue to "Assigned" Column in "Candidates for University Projects"
+            ⏳ Please note, you will be automatically unassigned if the issue isn't closed within **{{ total_days }} days** (by **{{ unassigned_date }}**). A maintainer can also add the "**{{ pin_label }}**" label to prevent automatic unassignment.
+          assignment_suggestion_comment: >
+            👋 Hey @{{ handle }}, looks like you’re eager to work on this issue—great! 🎉
+            It also looks like you skipped reading our [CONTRIBUTING.md](https://github.com/JabRef/jabref/blob/main/CONTRIBUTING.md), which explains exactly how to participate. No worries, it happens to the best of us.
+            Give it a read, and you’ll discover the ancient wisdom of assigning issues to yourself. Trust me, it’s worth it. 🚀
+      - name: Move issue corresponding column in "Candidates for University Projects"
         uses: m7kvqbe1/github-action-move-issues@main
-        # Action currently works for issues only - pre-condition: https://github.com/takanome-dev/assign-issue-action/issues/269 fixed
-        if: github.event_name == 'issue_comment'
+        if: ${{ steps.assign.outputs.assigned == 'yes' || steps.assign.outputs.unassigned == 'yes' }}
         with:
           github-token: ${{ secrets.GH_TOKEN_ACTION_MOVE_ISSUE }}
           project-url: "https://github.com/orgs/JabRef/projects/3"
@@ -45,9 +45,9 @@ jobs:
           ignored-columns: ""
           default-column: "Free to take"
           skip-if-not-in-project: true
-      - name: Move Issue to "Assigned" Column in "Good First Issues"
+      - name: Move issue corresponding column in "Good First Issues"
         uses: m7kvqbe1/github-action-move-issues@main
-        if: github.event_name == 'issue_comment'
+        if: ${{ steps.assign.outputs.assigned == 'yes' || steps.assign.outputs.unassigned == 'yes' }}
         with:
           github-token: ${{ secrets.GH_TOKEN_ACTION_MOVE_ISSUE }}
           project-url: "https://github.com/orgs/JabRef/projects/5"

.github/workflows/on-issue-labeled.yml

@@ -1,4 +1,4 @@
-name: On labeled issue
+name: On issue labeled
 
 on:
   issues:

.github/workflows/on-issue-unassigned.yml

@@ -0,0 +1,50 @@
+name: On issue unassigned
+
+on:
+  issues:
+     types:
+       - unassigned
+
+jobs:
+  ensure_column:
+    if: ${{ github.repository_owner == 'JabRef' }}
+    runs-on: ubuntu-latest
+    permissions:
+      issues: write
+    steps:
+      - name: Move Issue to "Free to take" Column in "Candidates for University Projects"
+        uses: m7kvqbe1/github-action-move-issues@main
+        with:
+          github-token: ${{ secrets.GH_TOKEN_ACTION_MOVE_ISSUE }}
+          project-url: "https://github.com/orgs/JabRef/projects/3"
+          target-labels: ""
+          target-column: "Free to take"
+          ignored-columns: ""
+          default-column: "Free to take"
+          skip-if-not-in-project: true
+      - name: Move Issue to "Free to take" Column in "Good First Issues"
+        uses: m7kvqbe1/github-action-move-issues@main
+        with:
+          github-token: ${{ secrets.GH_TOKEN_ACTION_MOVE_ISSUE }}
+          project-url: "https://github.com/orgs/JabRef/projects/5"
+          target-labels: ""
+          target-column: "Free to take"
+          ignored-columns: ""
+          default-column: "Free to take"
+          skip-if-not-in-project: true
+  remove_labels:
+    if: ${{ github.repository_owner == 'JabRef' }}
+    runs-on: ubuntu-latest
+    permissions:
+      issues: write
+      contents: read
+    steps:
+      - uses: actions/checkout@v4
+      - name: Remove assigned label
+        run: gh issue edit ${{ github.event.issue.number }} --remove-label "📍 Assigned"
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - name: Remove FirstTimeCodeContribution label
+        run: gh issue edit ${{ github.event.issue.number }} --remove-label "FirstTimeCodeContribution"
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/on-issue-unlabeled.yml

@@ -1,4 +1,4 @@
-name: On unlabeled issue
+name: On issue unlabeled
 
 on:
   issues:
@@ -33,3 +33,19 @@ jobs:
           ignored-columns: ""
           default-column: "Free to take"
           skip-if-not-in-project: true
+  remove_assignees:
+    if: ${{ github.repository_owner == 'JabRef' }}
+    runs-on: ubuntu-latest
+    permissions:
+      issues: write
+      contents: read
+    steps:
+      - uses: actions/checkout@v4
+      - name: Remove all assignees
+        run: |
+          ASSIGNEES=$(gh issue view ${{ github.event.issue.number }} --json assignees --template '{{range .assignees}}{{.login}} {{end}}')
+          for user in $ASSIGNEES; do
+            gh issue edit ${{ github.event.issue.number }} --remove-assignee "$user"
+          done
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/on-pr-closed.yml

@@ -1,11 +1,12 @@
-name: Mark issue as available
+name: On PR closed
 
 on:
   pull_request_target:
     types: [ closed ]
 
 jobs:
   unassign_issue:
+    name: Mark issue as available
     runs-on: ubuntu-latest
     if: github.event.action == 'closed' && !github.event.pull_request.merged
     permissions:
@@ -48,10 +49,14 @@ jobs:
           skip-if-not-in-project: true
       - uses: actions/checkout@v4
       - name: Remove assigned status
-        run : gh issue edit ${{ steps.get_issue_number.outputs.ticketNumber }} --remove-assignee ${{ github.event.pull_request.user.login }}
+        run: gh issue edit ${{ steps.get_issue_number.outputs.ticketNumber }} --remove-assignee ${{ github.event.pull_request.user.login }}
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - name: Remove assigned label
-        run : gh issue edit ${{ steps.get_issue_number.outputs.ticketNumber }} --remove-label "📍 Assigned"
+        run: gh issue edit ${{ steps.get_issue_number.outputs.ticketNumber }} --remove-label "📍 Assigned"
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - name: Remove FirstTimeCodeContribution label
+        run: gh issue edit ${{ steps.get_issue_number.outputs.ticketNumber }} --remove-label "FirstTimeCodeContribution"
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/on-pr-labeled.yml

@@ -1,4 +1,4 @@
-name: On labeled PR
+name: On PR labeled
 
 on:
   pull_request: