Skip to content

[Feature] readOnlyRootFilesystem for tei-gaudi when tei official tag version of container image is released #915

@lianhao

Description

@lianhao

Priority

Undecided

OS type

Ubuntu

Hardware type

Xeon-GNR

Running nodes

Single Node

Description

Future upstream tei will support gaudi devices, so we need to enable readOnlyRootFilesystem for future tei on gaudi devices:

Tested with the following modification to current tei helm chart:

diff --git a/helm-charts/common/tei/gaudi-values.yaml b/helm-charts/common/tei/gaudi-values.yaml
index aa8c36d..f10fc16 100644
--- a/helm-charts/common/tei/gaudi-values.yaml
+++ b/helm-charts/common/tei/gaudi-values.yaml
@@ -6,11 +6,9 @@ accelDevice: "gaudi"
 OMPI_MCA_btl_vader_single_copy_mechanism: "none"
 MAX_WARMUP_SEQUENCE_LENGTH: "512"
 image:
-  repository: ghcr.io/huggingface/tei-gaudi
-  tag: 1.5.0
+  tag: hpu-sha-943be86

-securityContext:
-  readOnlyRootFilesystem: false
+extraCmdArgs: [ "--dtype", "bfloat16"]
diff --git a/helm-charts/common/tei/templates/deployment.yaml b/helm-charts/common/tei/templates/deployment.yaml
index 825627e..86b4fbb 100644
--- a/helm-charts/common/tei/templates/deployment.yaml
+++ b/helm-charts/common/tei/templates/deployment.yaml
@@ -87,6 +87,11 @@ spec:
           {{- end }}
           args:
             - "--auto-truncate"
+          {{- if .Values.extraCmdArgs }}
+            {{- range .Values.extraCmdArgs }}
+            - {{ . | quote }}
+            {{- end }}
+          {{- end }}
           volumeMounts:
             - mountPath: /data
               name: model-volume
@@ -94,6 +99,8 @@ spec:
               name: shm
             - mountPath: /tmp
               name: tmp
+            - mountPath: /var/log/habana_logs
+              name: habana-logs
           ports:
             - name: http
               containerPort: {{ .Values.port }}
@@ -130,6 +137,8 @@ spec:
             sizeLimit: {{ .Values.shmSize }}
         - name: tmp
           emptyDir: {}
+        - name: habana-logs
+          emptyDir: {}
       {{- with .Values.nodeSelector }}
       nodeSelector:
         {{- toYaml . | nindent 8 }}

Metadata

Metadata

Assignees

No one assigned

    Labels

    Backlogfeatures in backlogfeatureNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions