--dry-run does not validate schema

[wchomik]

Context
Dry run mode in ocm add componentversions --dry-run does not validate schema.

Version
v0.341

To Reproduce
Steps to reproduce the behavior:

1. Create example component-constructor.yaml with one reference using incorrect semantic version:

components:
  - name: example.com/dryrun
    version: 0.0.1
    provider:
      name: example
    resources:
      - name: image-clamav-simple
        type: ociImage
        version: "1.4.2-38_base"
        access:
          type: ociArtifact
          imageReference: registry-1.docker.io/clamav/clamav:1.4.2-38_base@sha256:e7d108f30ea8f16935dbd12e4b58665f1bc148ce3dd59028cf04088330216910

2. Run ocm add componentversions --dry-run

> ocm add componentversions --dry-run --create --file ./ctf component-constructor.yaml
processing component-constructor.yaml...
  processing document 1...
    processing index 1
found 1 component
---
name: example.com/dryrun
provider:
  name: example
resources:
- access:
    imageReference: registry-1.docker.io/clamav/clamav:1.4.2-38_base@sha256:e7d108f30ea8f16935dbd12e4b58665f1bc148ce3dd59028cf04088330216910
    type: ociArtifact
  name: image-clamav-simple
  type: ociImage
  version: 1.4.2-38_base
version: 0.0.1

3. Run ocm add componentversions without --dry-run

> ocm add componentversions --create --file ./ctf component-constructor.yaml
processing component-constructor.yaml...
  processing document 1...
    processing index 1
found 1 component
adding component example.com/dryrun:0.0.1...
  adding resource ociImage: "name"="image-clamav-simple","version"="1.4.2-38_base"...
Error: failed adding component "example.com/dryrun"(component-constructor.yaml[1][1]): component.resources: Must validate one and only one schema (oneOf);component.resources.0.version: Does not match pattern '^[v]?(0|[1-9]\d*)(?:\.(0|[1-9]\d*))?(?:\.(0|[1-9]\d*))?(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$'

Actual behavior

1. ocm add componentversions --dry-run exits without returning error
2. ocm add componentversions without --dry-run returns error

Expected behavior

1. ocm add componentversions --dry-run returns error
2. ocm add componentversions without --dry-run returns error

Screenshots (optional)
If applicable, add screenshots to help explain your problem.

Environment

• windows
• linux
• mac

Additional Comments
According to @jakobmoellerdev :

We probably check for the constructor schema too late after dry run exits.

[morri-son]

@wchomik since I can see you used the CLI version 0.34.1 we just released two days ago: was this working before and is a regression or did you just stumbled upon this for the first time, so it never worked?

[wchomik]

@morri-son Initially, I encountered this issue in version 0.28.0. Before that, we hadn’t used --dry-run. I upgraded the CLI to 0.34.1 right before reporting this issue to ensure it hadn’t already been resolved.