Skip to content

Commit c5bb9df

Browse files
committed
Code review fixes
1 parent ab12f66 commit c5bb9df

5 files changed

Lines changed: 12 additions & 22 deletions

File tree

app/src/main/kotlin/ee/ria/DigiDoc/fragment/screen/InitScreen.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ import androidx.compose.runtime.Composable
3636
import androidx.compose.ui.Alignment
3737
import androidx.compose.ui.ExperimentalComposeUiApi
3838
import androidx.compose.ui.Modifier
39+
import androidx.compose.ui.graphics.Color
3940
import androidx.compose.ui.platform.testTag
4041
import androidx.compose.ui.res.painterResource
4142
import androidx.compose.ui.res.stringResource
@@ -91,7 +92,7 @@ fun InitScreen(
9192
Text(
9293
text = stringResource(id = R.string.digidoc_all_caps),
9394
style = MaterialTheme.typography.displayLarge,
94-
color = MaterialTheme.colorScheme.onPrimary,
95+
color = Color.White,
9596
modifier =
9697
modifier
9798
.padding(bottom = LPadding)
@@ -111,7 +112,7 @@ fun InitScreen(
111112
Text(
112113
text = stringResource(id = R.string.ria),
113114
style = MaterialTheme.typography.displaySmall,
114-
color = MaterialTheme.colorScheme.onPrimary,
115+
color = Color.White,
115116
modifier =
116117
modifier
117118
.padding(bottom = MPadding)

app/src/main/kotlin/ee/ria/DigiDoc/ui/component/menu/LanguageButton.kt

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import androidx.compose.foundation.layout.padding
3030
import androidx.compose.foundation.layout.size
3131
import androidx.compose.foundation.layout.wrapContentHeight
3232
import androidx.compose.material3.Button
33-
import androidx.compose.material3.ButtonColors
33+
import androidx.compose.material3.ButtonDefaults
3434
import androidx.compose.material3.Icon
3535
import androidx.compose.material3.MaterialTheme
3636
import androidx.compose.material3.Surface
@@ -81,11 +81,9 @@ fun LanguageButton(
8181
shape = RectangleShape,
8282
onClick = onClickItem,
8383
colors =
84-
ButtonColors(
84+
ButtonDefaults.buttonColors(
8585
containerColor = Color.Transparent,
86-
contentColor = MaterialTheme.colorScheme.onPrimary,
87-
disabledContainerColor = Color.Transparent,
88-
disabledContentColor = Color.Transparent,
86+
contentColor = Color.White
8987
),
9088
contentPadding =
9189
PaddingValues(

app/src/main/kotlin/ee/ria/DigiDoc/ui/component/shared/PrimaryButton.kt

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import androidx.compose.foundation.layout.fillMaxWidth
3131
import androidx.compose.foundation.layout.wrapContentSize
3232
import androidx.compose.foundation.shape.RoundedCornerShape
3333
import androidx.compose.material3.Button
34-
import androidx.compose.material3.ButtonColors
34+
import androidx.compose.material3.ButtonDefaults
3535
import androidx.compose.material3.MaterialTheme
3636
import androidx.compose.material3.Text
3737
import androidx.compose.runtime.Composable
@@ -85,23 +85,16 @@ fun PrimaryButton(
8585
contentPadding = PaddingValues(zeroPadding),
8686
enabled = enabled,
8787
colors =
88-
ButtonColors(
88+
ButtonDefaults.buttonColors(
8989
containerColor = containerColor,
9090
contentColor = contentColor,
91-
disabledContainerColor = MaterialTheme.colorScheme.background,
92-
disabledContentColor = MaterialTheme.colorScheme.tertiary,
9391
),
9492
border =
9593
if (isSubButton) {
9694
BorderStroke(
9795
width = SBorder,
9896
color = contentColor,
9997
)
100-
} else if (!enabled) {
101-
BorderStroke(
102-
width = SBorder,
103-
color = MaterialTheme.colorScheme.tertiary,
104-
)
10598
} else {
10699
BorderStroke(noBorderStroke, Transparent)
107100
},

app/src/main/kotlin/ee/ria/DigiDoc/ui/component/shared/PrimaryOutlinedButton.kt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ import androidx.compose.foundation.layout.fillMaxWidth
3232
import androidx.compose.foundation.layout.padding
3333
import androidx.compose.foundation.layout.size
3434
import androidx.compose.foundation.layout.width
35-
import androidx.compose.material3.ButtonColors
35+
import androidx.compose.material3.ButtonDefaults
3636
import androidx.compose.material3.Icon
3737
import androidx.compose.material3.MaterialTheme
3838
import androidx.compose.material3.OutlinedButton
@@ -91,11 +91,9 @@ fun PrimaryOutlinedButton(
9191
contentPadding = PaddingValues(zeroPadding),
9292
enabled = enabled,
9393
colors =
94-
ButtonColors(
94+
ButtonDefaults.buttonColors(
9595
containerColor = containerColor,
9696
contentColor = contentColor,
97-
disabledContainerColor = MaterialTheme.colorScheme.background,
98-
disabledContentColor = MaterialTheme.colorScheme.tertiary,
9997
),
10098
onClick = onClickItem,
10199
) {

app/src/main/kotlin/ee/ria/DigiDoc/ui/theme/Theme.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ private val DarkColorScheme =
6969
outlineVariant = DarkOutlineVariant,
7070
surface = DarkSurface,
7171
surfaceContainer = DarkSurfaceContainer,
72-
surfaceContainerLowest = DarkSurfaceContainerLow,
72+
surfaceContainerLowest = DarkSurfaceContainerLowest,
7373
surfaceContainerLow = DarkSurfaceContainerLow,
7474
surfaceContainerHigh = DarkSurfaceContainerHigh,
7575
surfaceContainerHighest = DarkSurfaceContainerHighest,
@@ -99,7 +99,7 @@ private val LightColorScheme =
9999
outlineVariant = LightOutlineVariant,
100100
surface = LightSurface,
101101
surfaceContainer = LightSurfaceContainer,
102-
surfaceContainerLowest = LightSurfaceContainerLow,
102+
surfaceContainerLowest = LightSurfaceContainerLowest,
103103
surfaceContainerLow = LightSurfaceContainerLow,
104104
surfaceContainerHigh = LightSurfaceContainerHigh,
105105
surfaceContainerHighest = LightSurfaceContainerHighest,

0 commit comments

Comments
 (0)