feat: Improve wait logic to a more elegant solution #1160 #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: christian.lutnik <[email protected]>
…ant-solution-open-feature#1160 # Conflicts: # providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java # providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java # providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolverTest.java
…re#1160 Signed-off-by: christian.lutnik <[email protected]>
github-actions
bot
requested review from
beeme1mr,
Kavindu-Dodan,
thisthat and
toddbaert
chrfwow
commented
Jan 21, 2025
| * for sync blocks. | ||
| */ | ||
| @Getter | ||
| public class EventsLock { |
There was a problem hiding this comment.
I moved this class out of the FlagdProvider to ensure no private fields are accessed and to keep the size of the file down.
However, I feel like the name is not approrpaite anymore, so please feel free to suggest a better one. Also, this new class is strongly coupled to the FlagdProvider, if you have any suggestions to make it cleaner please let me know
There was a problem hiding this comment.
maybe FlagdProviderSyncState or similar could be an appropriate name - or just SyncState or SyncResource - but to be fair, i am also not hundred percent happy with my suggestions
aepfli
approved these changes
Jan 21, 2025
providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java
Outdated
Show resolved
Hide resolved
providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/FlagdProviderTest.java
Outdated
Show resolved
Hide resolved
providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/EventsLock.java
Outdated
Show resolved
Hide resolved
| * for sync blocks. | ||
| */ | ||
| @Getter | ||
| public class EventsLock { |
There was a problem hiding this comment.
maybe FlagdProviderSyncState or similar could be an appropriate name - or just SyncState or SyncResource - but to be fair, i am also not hundred percent happy with my suggestions
…re#1160 Signed-off-by: christian.lutnik <[email protected]>
…re#1160 Signed-off-by: christian.lutnik <[email protected]>
…re#1160 Signed-off-by: christian.lutnik <[email protected]>
…re#1160 Signed-off-by: christian.lutnik <[email protected]>
…re#1160 Signed-off-by: christian.lutnik <[email protected]>
…re#1160 Signed-off-by: christian.lutnik <[email protected]>
|
|
…open-feature#1160 # Conflicts: # providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java
Signed-off-by: christian.lutnik <[email protected]>
aepfli
reviewed
Feb 17, 2025
providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/ConfigCucumberTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
aepfli
reviewed
Feb 18, 2025
...ers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/steps/ProviderSteps.java
Show resolved
Hide resolved
Signed-off-by: christian.lutnik <[email protected]>
Signed-off-by: christian.lutnik <[email protected]>
aepfli
approved these changes
Feb 18, 2025
…open-feature#1160 # Conflicts: # providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java # providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/steps/EventSteps.java
Signed-off-by: christian.lutnik <[email protected]>
aepfli
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Adds a better wait logic to wait for the initialization of the
FlagdProvider.With these changes, it is not advisable to restart a
FlagdProvideronce it has been shut down.Related Issues
Fixes #1160