Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation tab unusable when long variable names are used for answers in checkboxes, choice & radio #4636

Closed
LaurensBurger opened this issue Sep 6, 2024 · 2 comments · Fixed by open-formulieren/formio-builder#183 or #4748
Closed

Translation tab unusable when long variable names are used for answers in checkboxes, choice & radio #4636

LaurensBurger opened this issue Sep 6, 2024 · 2 comments · Fixed by open-formulieren/formio-builder#183 or #4748
Assignees
@robinmolen
Labels
bug Something isn't working owner: maykin

Comments

@LaurensBurger
Copy link
Collaborator

LaurensBurger commented Sep 6, 2024 •
edited
Loading

Product versie / Product version

2.7.x

Customer reference

LV 194

Omschrijf het probleem / Describe the bug

When a the answers user rather long variable names they cause parts of the translation tab to slide under adjacent components:
image
rendering the tab useless as the user is not able to even click the "EN" part or comfortably add/edit the translations.

Breaking these long values should solve this issue - but i'm also not sure why these values should even be displayed at all in this tab - as it would not provide much help with translations?
@LaurensBurger LaurensBurger added bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels Sep 6, 2024
@joeribekker
Copy link
Contributor

joeribekker commented Sep 9, 2024 •
edited
Loading

Refinement: Word-break would be the easiest fix here. I guess zooming out could work as a workaround.

Just tested it with @vaszig: Adding word-break: break-word to the location and word-break: break-all to the value, it would be ok.

@joeribekker joeribekker removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Sep 9, 2024
@robinmolen robinmolen linked a pull request Sep 25, 2024 that will close this issue
🐛 [open-formulieren/open-forms#4636] Preventing large values from breaking the table open-formulieren/formio-builder#183
Merged
@robinmolen
Copy link
Contributor

@joeribekker Who is the owner of this issue?

@sergei-maertens sergei-maertens mentioned this issue Oct 2, 2024
Merged
robinmolen added a commit to open-formulieren/formio-builder that referenced this issue Oct 7, 2024
@robinmolen
💄 [open-formulieren/open-forms#4636] Moved styling to scss file
25543de
robinmolen added a commit to open-formulieren/formio-builder that referenced this issue Oct 7, 2024
@robinmolen
🐛 [open-formulieren/open-forms#4636] Preventing large values to break…
a8442b1 
…ing the table
robinmolen added a commit to open-formulieren/formio-builder that referenced this issue Oct 8, 2024
@robinmolen
💄 [open-formulieren/open-forms#4636] Fixed custom table styling
094a19a
robinmolen added a commit to open-formulieren/formio-builder that referenced this issue Oct 8, 2024
@robinmolen
🚚 [open-formulieren/open-forms#4636] Moved styling import to library …
22a5ab3 
…index
sergei-maertens added a commit to open-formulieren/formio-builder that referenced this issue Oct 10, 2024
@sergei-maertens
✅ [open-formulieren/open-forms#4636] Add story for text wrapping in t…
4d08cd7 
…ranslations table
sergei-maertens added a commit to open-formulieren/formio-builder that referenced this issue Oct 10, 2024
@sergei-maertens
✅ [open-formulieren/open-forms#4636] Add story for text wrapping in t…
4b009bb 
…ranslations table
sergei-maertens added a commit to open-formulieren/formio-builder that referenced this issue Oct 10, 2024
@sergei-maertens
Merge pull request #183 from open-formulieren/issue/4636-translation-…
8113a80 
…tab-unusable-with-long-values

🐛 [open-formulieren/open-forms#4636] Preventing large values from breaking the table
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Oct 10, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Development Oct 10, 2024
sergei-maertens added a commit that referenced this issue Oct 10, 2024
@sergei-maertens
⬆️ Upgrade to formio-builder 0.30
8c43d7d 
Closes #4636
Closes #4637

This also exposes the ProductPrice experimental component, which will
likely be gated behind a feature flag for the full 3.0 release.
@sergei-maertens sergei-maertens mentioned this issue Oct 10, 2024
Merged
9 tasks
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Oct 10, 2024
robinmolen pushed a commit that referenced this issue Oct 15, 2024
@sergei-maertens @robinmolen
⬆️ Upgrade to formio-builder 0.30
b2e2436 
Closes #4636
Closes #4637

This also exposes the ProductPrice experimental component, which will
likely be gated behind a feature flag for the full 3.0 release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robinmolen robinmolen

Labels
bug Something isn't working owner: maykin
Projects
Development
Archived in project
Milestone
No milestone
4 participants
@joeribekker @sergei-maertens @LaurensBurger @robinmolen