Fix broken objects api variable mappings #5021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-maertens
added
the
needs-backport
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5021 +/- ##
=======================================
Coverage 96.63% 96.63%
=======================================
Files 761 761
Lines 26004 26004
Branches 3395 3395
=======================================
Hits 25129 25129
Misses 610 610
Partials 265 265 ☔ View full report in Codecov by Sentry. |
sergei-maertens
changed the title
...orms/js/components/admin/form_design/registrations/objectsapi/ObjectsApiOptionsFormFields.js
Outdated
Show resolved
Hide resolved
Because the `version` configuration option was absent for freshly added registration backends, you can't immediately configure them in the variables table unless you save the form first and then edit it. Another crash has been observed where doing the above resulted in the variables table not rendering (crashing), but I wasn't able to reproduce this. I suspect it's because the variablesMapping config option was undefined or null which may happen because of toggling between v1/v2. A fix worth backporting, but no need for urgent hotfix releases since you can work around it by saving the form after adding the registration backend, and then finishing the registration configuration in the variables table.
sergei-maertens
force-pushed
the
hotfix/broken-objects-api-variable-mappings
branch
from
226f1b3 to
0a48c48
Compare
sergei-maertens
deleted the
hotfix/broken-objects-api-variable-mappings
branch
sergei-maertens
added a commit
that referenced
this pull request
Jan 23, 2025
Because the `version` configuration option was absent for freshly added registration backends, you can't immediately configure them in the variables table unless you save the form first and then edit it. Another crash has been observed where doing the above resulted in the variables table not rendering (crashing), but I wasn't able to reproduce this. I suspect it's because the variablesMapping config option was undefined or null which may happen because of toggling between v1/v2. A fix worth backporting, but no need for urgent hotfix releases since you can work around it by saving the form after adding the registration backend, and then finishing the registration configuration in the variables table. Backport-of: #5021
|
Backported to 3.0.x in c7e5d89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(no issue created, was reported by Joeri yesterday)
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shDockerfile/scripts
./binfolderCommit hygiene